From owner-freebsd-current@FreeBSD.ORG Sun Jan 15 08:31:16 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 697681065672 for ; Sun, 15 Jan 2012 08:31:16 +0000 (UTC) (envelope-from conrads@cox.net) Received: from eastrmfepi108.cox.net (eastrmfepi108.cox.net [68.230.241.204]) by mx1.freebsd.org (Postfix) with ESMTP id 020E88FC08 for ; Sun, 15 Jan 2012 08:31:15 +0000 (UTC) Received: from eastrmimpo109.cox.net ([68.230.241.222]) by eastrmfepo202.cox.net (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP id <20120115081128.WHRT2803.eastrmfepo202.cox.net@eastrmimpo109.cox.net>; Sun, 15 Jan 2012 03:11:28 -0500 Received: from serene.no-ip.org ([98.164.86.55]) by eastrmimpo109.cox.net with bizsmtp id MkBL1i0011BeFqy02kBQ2S; Sun, 15 Jan 2012 03:11:28 -0500 X-CT-Class: Clean X-CT-Score: 0.00 X-CT-RefID: str=0001.0A02020A.4F128A30.006F,ss=1,re=0.000,fgs=0 X-CT-Spam: 0 X-Authority-Analysis: v=1.1 cv=v7GbILHnR1xQ6JOQ0tpByaeo/qX3otcUiWK95upJFOE= c=1 sm=1 a=DPtQzSQXmXEA:10 a=G8Uczd0VNMoA:10 a=8nJEP1OIZ-IA:10 a=fdHYxQQoAueMHNSmXppgDg==:17 a=6I5d2MoRAAAA:8 a=kviXuzpPAAAA:8 a=JTTsJ0TddPbK8hFucNoA:9 a=DsY2UJq2VAGx-an-rcYA:7 a=wPNLvfGTeEIA:10 a=SV7veod9ZcQA:10 a=STBOWvXN29oA:10 a=4vB-4DCPJfMA:10 a=fdHYxQQoAueMHNSmXppgDg==:117 X-CM-Score: 0.00 Authentication-Results: cox.net; none Received: from cox.net (localhost [127.0.0.1]) by serene.no-ip.org (8.14.5/8.14.5) with ESMTP id q0F8B6sE014882; Sun, 15 Jan 2012 02:11:10 -0600 (CST) (envelope-from conrads@cox.net) Date: Sun, 15 Jan 2012 02:11:01 -0600 From: "Conrad J. Sabatier" To: Chris Rees Message-ID: <20120115021101.11615318@cox.net> In-Reply-To: References: <4F114577.30201@FreeBSD.org> <4F119C40.2080503@gwdg.de> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Subject: Re: HEADS UP: set_rcvar() removed from rc.subr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 08:31:16 -0000 On Sat, 14 Jan 2012 15:30:15 +0000 Chris Rees wrote: > On 14 January 2012 15:16, Rainer Hurling wrote: > > On 14.01.2012 10:05 (UTC+1), Doug Barton wrote: > >> > >> Howdy, > >> > >> Per discussion in freebsd-rc@, I have removed set_rcvar() from > >> rc.subr. The concept of set_rcvar() was nice in theory, but the > >> forks it creates are a drag on the startup process, which is > >> especially noticeable on slower systems, such as embedded ones. > >> > >> I have no plans to MFC this change, so it should only affect users > >> who are actually on 10-current. If you have scripts > >> in /usr/local/etc/rc.d (which if you have ports installed you > >> almost certainly do) ... > >> > >> to make the change by hand, change this: > >> > >> name=3Dfoo > >> rcvar=3D`set_rcvar` > >> > >> to: > >> > >> name=3Dfoo > >> rcvar=3Dfoo_enable > >> > >> I didn't bump PORTREVISIONs because the change only applies to > >> HEAD. But all of the ports are updated, so if you can't figure out > >> how to make the change, just reinstall it. > >> > >> > >> Doug > > > > > > Seems that ports-mgmt/tinderbox needs an update like this: > > > > files/patch-etc__rc.d__tinderd > > > > --- etc/rc.d/tinderd.orig =A0 =A0 =A0 2011-11-20 07:01:09.000000000 +01= 00 > > +++ etc/rc.d/tinderd =A0 =A02012-01-14 16:07:38.000000000 +0100 > > @@ -16,7 +16,7 @@ > > =A0. /etc/rc.subr > > > > =A0name=3D"tinderd" > > -rcvar=3D`set_rcvar` > > +rcvar=3Dtinderd_enable > > > > =A0# read settings, set default values > > =A0load_rc_config "${name}" > > >=20 > I'm in the process of fixing this upstream. >=20 > Chris Chris, if you're working on fixing ports' rc files, here are a few potential "gotchas" to be aware of: I did a little quick-and-dirty sed substitution on all of my files under /usr/local/etc/rc.d, plugging in "$filename_enable" in place of `set_rcvar`. This works just fine for all but a few. Filenames containing hyphens must have underscores substituted (e.g., avahi-daemon, etc.). In a few cases, the rcvar is different from the filename in other ways. The only ones I came across in my local installation were sa-spamd (spamd_enable) and mysql-server (mysql_enable). There are bound to be others like this in ports. Overall, though, it was a simple matter to fix up the scripts I had installed already. If I can be of any assistance in tidying up the ports tree, let me know. Conrad --=20 Conrad J. Sabatier conrads@cox.net