From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 1 22:20:10 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 628D116A420 for ; Wed, 1 Mar 2006 22:20:10 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1E8543D66 for ; Wed, 1 Mar 2006 22:20:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k21MK3vW092263 for ; Wed, 1 Mar 2006 22:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k21MK3XW092262; Wed, 1 Mar 2006 22:20:03 GMT (envelope-from gnats) Resent-Date: Wed, 1 Mar 2006 22:20:03 GMT Resent-Message-Id: <200603012220.k21MK3XW092262@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Neel Natu Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B9E216A420 for ; Wed, 1 Mar 2006 22:12:36 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id A42CE43D46 for ; Wed, 1 Mar 2006 22:12:35 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k21MCZ4B004078 for ; Wed, 1 Mar 2006 22:12:35 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k21MCZEo004077; Wed, 1 Mar 2006 22:12:35 GMT (envelope-from nobody) Message-Id: <200603012212.k21MCZEo004077@www.freebsd.org> Date: Wed, 1 Mar 2006 22:12:35 GMT From: Neel Natu To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: misc/93998: panic in libstand when closing raw disk device X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2006 22:20:10 -0000 >Number: 93998 >Category: misc >Synopsis: panic in libstand when closing raw disk device >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 01 22:20:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Neel Natu >Release: 6.0-RELEASE >Organization: >Environment: FreeBSD neel3.silverspringnet.com. 6.0-RELEASE FreeBSD 6.0-RELEASE #0: Thu Nov 3 09:36:13 UTC 2005 root@x64.samsco.home:/usr/obj/usr/src/sys/GENERIC i386 >Description: We have a modified loader(8) than opens a raw disk partition using libstand open(), reads stuff from it and does a close() on the file descriptor. This close() panics because it tries to free 'f_rabuf'. This is because it has not been initialized in open() for raw disk devices. >How-To-Repeat: Not sure how to exercise this from the vanilla loader. >Fix: =================================================================== RCS file: /cvsroot/eng/gw/lib/libstand/open.c,v retrieving revision 1.1.1.1.16.1 retrieving revision 1.2.14.1 diff -u -r1.1.1.1.16.1 -r1.2.14.1 --- open.c 16 Feb 2006 01:44:27 -0000 1.1.1.1.16.1 +++ open.c 18 Feb 2006 06:47:00 -0000 1.2.14.1 @@ -117,6 +117,7 @@ /* see if we opened a raw device; otherwise, 'file' is the file name. */ if (file == (char *)0 || *file == '\0') { f->f_flags |= F_RAW; + f->f_rabuf = NULL; return (fd); } >Release-Note: >Audit-Trail: >Unformatted: