From owner-dev-commits-src-main@freebsd.org Thu Sep 30 13:33:38 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C1666B14DC for ; Thu, 30 Sep 2021 13:33:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HKvMk3Vtpz3kDW for ; Thu, 30 Sep 2021 13:33:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92b.google.com with SMTP id b34so4199006uad.8 for ; Thu, 30 Sep 2021 06:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qoEfhX16VGpVnWzC/7+0WdYZEAS1KoA9urNmROre28A=; b=hhYnNcGQ8VLIe/1EVQKmYkt8Hwj56KZ6IjHqUD7BiAAEAhGeYgLGjITDAxRp2LZG85 EKo8lvWelDV7cKsTM+wVfUEiFHDvE2Y7HQQ/rr1GtZG/GipWmCU1lBxn8LEV0gdkuheG REiFOcVrQ/GAdougTucwfFS0kbvrzJetUzuC49E6qeJNUY/fpPVh82f+bWBqK9GAtdIr KnkuTukb1wd1yDslMoJz4lWyOEaq5LkkVgnHPdtt5qJN4LPEtX49JvtkbN3FHUN19LHH 9PjQrclxBXWTC+1YoeuZK6b08zwWEhrvzJvETHnqWs0BNi1Nj5hvAFXCrA3WCP1m4hoc nsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qoEfhX16VGpVnWzC/7+0WdYZEAS1KoA9urNmROre28A=; b=TOMV9Vc4L1Ys3I0Zr9OAALU16Qc51a1CwbLLzirsoyP6vnROQd9nNaIMjBpA1pRjBw dfcnsc1URDg822pQaBZ9G+9icUjoDkaJpJ9A9rdgUxieHSBZMgEQzPcLSXdT3Yu3BLe1 17q/OW02Tpm6WcqfrwX7XVZGZ+GGOrOP+1VhBIbGtK6pEQxpaQ/+xRW0/iUH4tU6vbXq v0GAskDkLsBCKQIcV8v2taS5aK2GRY0H3+b5wgQlvVVCKosAmX6CUfhDQFAIjGeZQEGq WlbXs+vaBNeLHe1TK9tN0A2QgkMk+J09G5oIqoc5MkXHGT+orY9Mdc5F/46/U+n3I2cI V8mA== X-Gm-Message-State: AOAM533d/Cjf4SWsuEszaivYqpGcqVaa+zoiJ1wd2Ljuh9Vv0Er6W3gH 3V9SLL81rIQlrNJEE6btbf40XC6IKtaCvdi0yUy5Pg== X-Google-Smtp-Source: ABdhPJwTCnfHnrc5KlZVdXG9PwfHI/OQEYdd33ASU+E5fz4PMb/Ary6n/NHmD9gybaqECLJlhlD59vrPqwgSmXs3ZKU= X-Received: by 2002:a9f:23d0:: with SMTP id 74mr5406973uao.69.1633008817739; Thu, 30 Sep 2021 06:33:37 -0700 (PDT) MIME-Version: 1.0 References: <202109300200.18U20EZD084710@gitrepo.freebsd.org> <20210930111120.e038ca0a2a3c770f4778fa84@bidouilliste.com> In-Reply-To: <20210930111120.e038ca0a2a3c770f4778fa84@bidouilliste.com> From: Warner Losh Date: Thu, 30 Sep 2021 07:33:26 -0600 Message-ID: Subject: Re: git: 79a100e28e3c - main - bluetooth: complete removal of ng_h4 To: Emmanuel Vadot Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4HKvMk3Vtpz3kDW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 13:33:38 -0000 On Thu, Sep 30, 2021 at 3:11 AM Emmanuel Vadot wrote: > On Thu, 30 Sep 2021 02:00:14 GMT > Warner Losh wrote: > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=79a100e28e3c814773bb4c1826cfa25fbe31140e > > > > commit 79a100e28e3c814773bb4c1826cfa25fbe31140e > > Author: Warner Losh > > AuthorDate: 2021-09-05 18:41:16 +0000 > > Commit: Warner Losh > > CommitDate: 2021-09-30 02:00:02 +0000 > > > > bluetooth: complete removal of ng_h4 > > > > The ng_h4 module was disconnected 13 years ago when the tty later was > > locked by Ed. It completely fails to compile, and has a number of > false > > positives for Giant use. Remove it for lack of interest. Bluetooth > has > > largely (completely?) moved on from bluetooth over UART transport. > > > > OK'd by: emax > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D31846 > > Every BT+WIFI combo chip used in SBC uses uart for bluetooth. > I have no idea if it uses this or need something else as I've never > looked. > But anyway, if it fails to compile now I'm fine with removing it, if > someone wants to add support for bluetooth to SBC they could always > revive this code. > Yes. If there's a need, we can revive the code... once it's fixed... It looked to take a bit more time than I had.... I've had others make the same or similar correction... Warner