From owner-freebsd-bugs@FreeBSD.ORG  Mon Feb 21 18:50:12 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 920EE106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 21 Feb 2011 18:50:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 656CD8FC27
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 21 Feb 2011 18:50:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p1LIoCQY070942
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 21 Feb 2011 18:50:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p1LIoCnF070939;
	Mon, 21 Feb 2011 18:50:12 GMT (envelope-from gnats)
Date: Mon, 21 Feb 2011 18:50:12 GMT
Message-Id: <201102211850.p1LIoCnF070939@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Cc: 
Subject: Re: misc/143831: [bsd.own.mk] [patch] Fix missing atm -> bsnmp
 dependency
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Feb 2011 18:50:12 -0000

The following reply was made to PR misc/143831; it has been noted by GNATS.

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: bug-followup@FreeBSD.org, gcooper@FreeBSD.org
Cc: miwi@FreeBSD.org
Subject: Re: misc/143831: [bsd.own.mk] [patch] Fix missing atm -> bsnmp
 dependency
Date: Mon, 21 Feb 2011 18:46:20 +0000 (UTC)

 Hi,
 
 I think the patch is too excessive, as is the following in bsd.own.mk:
 
 .if ${MK_NETGRAPH} == "no"
 MK_ATM:=        no
 MK_BLUETOOTH:=  no
 .endif
 
 To my understanding disabling all of atm if we don't have netgraph
 seems wrong but probably was an easy path at some point.
 
 Without testing I think the following patch should be enough:
 
 Index: rescue/rescue/Makefile
 ===================================================================
 --- rescue/rescue/Makefile      (revision 218757)
 +++ rescue/rescue/Makefile      (working copy)
 @@ -99,7 +99,7 @@ CRUNCH_PROGS_sbin= atacontrol badsect                         \
          restore rcorder route routed rtquery rtsol savecore     \
          spppcontrol swapon sysctl tunefs umount
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   CRUNCH_PROGS_sbin+= atmconfig
   .endif
 
 Index: sbin/Makefile
 ===================================================================
 --- sbin/Makefile       (revision 218757)
 +++ sbin/Makefile       (working copy)
 @@ -73,7 +73,7 @@ SUBDIR=adjkerntz \
          tunefs \
          umount \
 
 -.if ${MK_ATM} != "no"
 +.if ${MK_ATM} != "no" && ${MK_BSNMP} != "no"
   SUBDIR+=       atm
   .endif
 
 
 BTw, the test case of `make -C sbin/atm WITHOUT_BSNMP=yes depend`
 seems wrong as well as that actually ignores some checks in place.
 
 /bz
 
 -- 
 Bjoern A. Zeeb                                 You have to have visions!
           Stop bit received. Insert coin for new address family.