From owner-freebsd-multimedia@FreeBSD.ORG Wed Dec 12 18:46:23 2007 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30F0216A418 for ; Wed, 12 Dec 2007 18:46:23 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao106.cox.net (eastrmmtao106.cox.net [68.230.240.48]) by mx1.freebsd.org (Postfix) with ESMTP id DF0E313C46E for ; Wed, 12 Dec 2007 18:46:22 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo03.cox.net ([68.1.16.126]) by eastrmmtao106.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20071212184623.GHTB476.eastrmmtao106.cox.net@eastrmimpo03.cox.net>; Wed, 12 Dec 2007 13:46:23 -0500 Received: from mezz.mezzweb.com ([24.255.149.218]) by eastrmimpo03.cox.net with bizsmtp id Puf11Y0074iy4EG0000000; Wed, 12 Dec 2007 13:39:02 -0500 Date: Wed, 12 Dec 2007 12:46:14 -0600 To: "Jona Joachim" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii MIME-Version: 1.0 References: <200712060650.lB66o4kF022891@freefall.freebsd.org> <20071207231159.7ec5cc90@spaceman.my.domain> <20071211124248.6acc1382@hcl-club.lu> <20071212141050.297c51db@hcl-club.lu> Content-Transfer-Encoding: Quoted-Printable Message-ID: In-Reply-To: <20071212141050.297c51db@hcl-club.lu> User-Agent: Opera Mail/9.24 (Linux) Cc: freebsd-multimedia@freebsd.org Subject: Re: ports/118458: [UPDATE] multimedia/handbrake X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2007 18:46:23 -0000 On Wed, 12 Dec 2007 07:10:50 -0600, Jona Joachim wrote= : > On Tue, 11 Dec 2007 11:27:11 -0600 > "Jeremy Messenger" wrote: > >> On Tue, 11 Dec 2007 05:42:48 -0600, Jona Joachim >> wrote: >> >> >> > I tested it with your latest changes on my system and everything >> > works as expected, on-the-fly DVD ripping was also fine. >> > >> > However it doesn't build in tinderbox. >> > >> > Here is the whole output: >> > http://www.hcl-club.lu/~jaj/stuff/handbrake-0.9.1.log >> > >> > The main problem is that libvorbis doesn't build because it doesn't= >> > find libogg: >> > >> > checking for Ogg... no >> > ... >> > configure: error: must have Ogg installed! >> > >> > (on line 6678) >> >> Umm... I think I see a problem with it. It couldn't find ogg, >> because pkg-config does not exist. I have built handbrake and see in >> the config.log of libvorbis: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> configure:20133: found /usr/local/bin/pkg-config >> configure:20146: result: /usr/local/bin/pkg-config >> configure:20164: checking for ogg >=3D 1.0 >> configure:20168: result: yes >> configure:20172: checking OGG_CFLAGS >> configure:20175: result: -I/usr/local/include >> configure:20178: checking OGG_LIBS >> configure:20181: result: -L/usr/local/lib -logg >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Ouch, it built with my system's libogg rather than handbrake's >> libogg. It needs to be tweak the PKG_CONFIG_PATH by set it to >> 'PKG_CONFIG_PATH=3D$CONTRIB/lib/pkgconfig'. But after look inside >> libvorbis that there has options: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --with-ogg=3DPFX Prefix where libogg is installed (optional) >> --with-ogg-libraries=3DDIR Directory where libogg library is >> installed (optional) >> --with-ogg-includes=3DDIR Directory where libogg header files ar= e >> installed (optional) >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Let's add '--with-ogg-includes=3D$CONTRIB/include >> --with-ogg-libraries=3D$CONTRIB/lib' in files/patch-contrib-Jamfile >> after that '--with-ogg=3D$CONTRIB' to see if it helps in your >> tinderbox. If not then we will have to go with PKG_CONFIG_PATH stuff.= > > It builds fine in tinderbox with your latest patch! > I also tested the resulting binary in different scenarios and > everything was ok. > >> > The are some other minor problems. >> >> What other minor problems? > > I think the only thing that remains is: > > vhook/drawtext.c:61:10: error: #include expects "FILENAME" or > vhook/drawtext.c:62:10: error: #include expects "FILENAME" or > > on line 642 and 643 in the updated > http://www.hcl-club.lu/~jaj/stuff/handbrake-0.9.1.log > > these errors concern the following lines in > contrib/ffmpeg/vhook/drawtext.c: > #include FT_FREETYPE_H > #include FT_GLYPH_H > > Those 2 defines aren't referenced in any other file. Strange thing is > it only happens in tinderbox. However these errors are not fatal to th= e > built. Add freetype2 dependency should fix it. Add this in Makefile. LIB_DEPENDS=3D freetype.9:${PORTSDIR}/print/freetype2 I have a last question for you. Do you want to maintain this port? Yes o= r = no? If no, multimedia@ will continue try to do with our best. After this= , = I shall commit the update of handbrake (with freetype2 include). >> > Unfortunately tinderbox always cleans the work folder after it >> > finishes. I don't know how to make it keep it to have a look at >> > what's going wrong. >> >> Are you using MC tinderbox? If yes, there has README at about 290 >> line: >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> Sometimes, the log alone is not sufficient for figuring out >> why a port failed to build. In such cases, one must also see the >> port's work directory. To have Tinderbox save this, create an empty >> file called ``.keep'' in the port's directory, and the work directory= >> will be tarred, compressed, and copied to ${pb}/wrkdirs/{BUILD} >> (where {BUILD} is the Build name). >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Thanks, that's what I needed! :) No problem. Cheers, Mezz >> I used to have a MC tinderbox, but that system has died some months >> ago. I haven't buy a cheap system for tinderbox yet. >> >> Cheers, >> Mezz > > > Regards, > Jona -- = mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org http://wiki.freebsd.org/multimedia - multimedia@FreeBSD.org