From owner-freebsd-acpi@FreeBSD.ORG  Wed Jun 16 13:11:09 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1C45116A4CE
	for <freebsd-acpi@freebsd.org>; Wed, 16 Jun 2004 13:11:09 +0000 (GMT)
Received: from les.ath.cx (12.41.244.43.ap.yournet.ne.jp [43.244.41.12])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5A44243D60
	for <freebsd-acpi@freebsd.org>; Wed, 16 Jun 2004 13:11:08 +0000 (GMT)
	(envelope-from qhwt+freebsd-acpi@les.ath.cx)
Received: (qmail 37681 invoked by uid 1000); 16 Jun 2004 13:10:55 -0000
Date: Wed, 16 Jun 2004 22:10:55 +0900
From: YONETANI Tomokazu <qhwt+freebsd-acpi@les.ath.cx>
To: nate@root.org
Message-ID: <20040616131055.GA37637@les.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.6i
cc: freebsd-acpi@freebsd.org
Subject: cx_usage
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jun 2004 13:11:09 -0000

Hello.
What do you think about the following changes?

- print 100% instead of 99% when there's only 1 Cx state, and 0%
  when the sum is zero.
- two digits from fractional part of each percentage are shown;
  my Laptop PC barely enters into C3 state and hw.acpi.cpu.cx_usage
  is almost always "0% 99% 0%" after revision 1.39. it's now shown as
  "0.00% 99.96% 0.03%"

--- /home/build/freebsd/current/sys/dev/acpica/acpi_cpu.c	2004-06-16 15:27:25.000000000 +0900
+++ acpi_cpu.c	2004-06-16 15:24:38.000000000 +0900
@@ -1046,15 +1051,21 @@
     struct sbuf	 sb;
     char	 buf[128];
     int		 i;
-    u_int	 sum;
+    u_int	 frac, real, sum;
 
-    /* Avoid divide by 0 potential error. */
-    sum = 1;
+    sum = 0;
     for (i = 0; i < cpu_cx_count; i++)
 	sum += cpu_cx_stats[i];
     sbuf_new(&sb, buf, sizeof(buf), SBUF_FIXEDLEN);
-    for (i = 0; i < cpu_cx_count; i++)
-	sbuf_printf(&sb, "%u%% ", (cpu_cx_stats[i] * 100) / sum);
+    for (i = 0; i < cpu_cx_count; i++) {
+	if (sum == 0)
+	    sbuf_printf(&sb, "0%% ");
+	else {
+	    real = cpu_cx_stats[i] * 100;
+	    frac = (real % sum) * 100;
+	    sbuf_printf(&sb, "%u.%02u%% ", real / sum, frac / sum);
+	}
+    }
     sbuf_trim(&sb);
     sbuf_finish(&sb);
     sysctl_handle_string(oidp, sbuf_data(&sb), sbuf_len(&sb), req);