From owner-cvs-src@FreeBSD.ORG Fri Aug 27 16:27:49 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP id DBC8616A4CF
for <cvs-src@FreeBSD.org>; Fri, 27 Aug 2004 16:27:49 +0000 (GMT)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
by mx1.FreeBSD.org (Postfix) with ESMTP id EF94043D7B
for <cvs-src@FreeBSD.org>; Fri, 27 Aug 2004 16:27:48 +0000 (GMT)
(envelope-from andre@freebsd.org)
Received: (qmail 58595 invoked from network); 27 Aug 2004 16:26:26 -0000
Received: from unknown (HELO freebsd.org) ([62.48.0.53])
(envelope-sender <andre@freebsd.org>)
by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
for <max@love2party.net>; 27 Aug 2004 16:26:26 -0000
Message-ID: <412F6108.8C380C17@freebsd.org>
Date: Fri, 27 Aug 2004 18:27:52 +0200
From: Andre Oppermann <andre@freebsd.org>
X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Max Laier <max@love2party.net>
References: <200408271516.i7RFGO8L061926@repoman.freebsd.org>
<200408271812.18748.max@love2party.net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man4 ipfirewall.4 src/share/man/man9
pfil.9 src/sys/alpha/conf GENERIC src/sys/amd64/conf GENERIC
src/sys/conf NOTES files options src/sys/i386/conf GENERIC
src/sys/ia64/conf GENERIC SKI src/sys/modules/bridge Makefile ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Aug 2004 16:27:50 -0000
Max Laier wrote:
>
> On Friday 27 August 2004 17:16, Andre Oppermann wrote:
> > andre 2004-08-27 15:16:24 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > share/man/man4 ipfirewall.4
> > share/man/man9 pfil.9
> > sys/alpha/conf GENERIC
> > sys/amd64/conf GENERIC
> > sys/conf NOTES files options
> > sys/i386/conf GENERIC
> > sys/ia64/conf GENERIC SKI
> > sys/modules/bridge Makefile
> > sys/net bridge.c
> > sys/netinet ip_fastfwd.c ip_fw_pfil.c ip_input.c
> > ip_output.c ip_var.h
> > sys/netinet6 ip6_forward.c ip6_input.c ip6_output.c
> > ip6_var.h
> > sys/pc98/conf GENERIC
> > sys/powerpc/conf GENERIC
> > sys/sparc64/conf GENERIC
> > . UPDATING
> > Log:
> > Always compile PFIL_HOOKS into the kernel and remove the associated
> > kernel compile option. All FreeBSD packet filters now use the PFIL_HOOKS
> > API and thus it becomes a standard part of the network stack.
> >
> > If no hooks are connected the entire packet filter hooks section and
> > related activities are jumped over. This removes any performance impact if
> > no hooks are active.
>
> Great!!!
>
> Maybe we should hide:
> if (inet_pfil_hook.ph_busy_count == -1)
> behind a macro in case we modify the locking for pfil_hooks in the future. I
> am thinking of something like:
> if (PFIL_IS_EMPTY(&inet_pfil_hook))
Checking for (inet_pfil_hook.ph_busy_count == -1) is the official to see if
there are any hooks connected. I don't think we need to abstract this in a
macro.
--
Andre