Date: 22 Jan 2002 23:21:36 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Mark Murray <mark@grondar.za> Cc: Ruslan Ermilov <ru@FreeBSD.org>, Mark Murray <markm@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.libnames.mk Message-ID: <xzpvgdukowf.fsf@flood.ping.uio.no> In-Reply-To: <200201222152.g0MLqVt61756@grimreaper.grondar.org> References: <xzp8zaqm6nm.fsf@flood.ping.uio.no> <200201222152.g0MLqVt61756@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Mark Murray <mark@grondar.za> writes:
> The counter-aurgument is a libtelnet-style thing where you make the
> libraries but do not install them. Then, telnet can link against
> libtelnet.a and be done with it.
That's exactly what I don't understand: why link libssh statically
into ssh, sshd etc? I can't see that we save anything by doing that -
quite to the contrary, we increase the size of these binaries as well
as their memory footprint when more than one of them is running at the
same time. Not counting PAM, we have nine binaries in the system that
link with libssh (scp, sftp, ssh, ssh-add, ssh-agent, ssh-keygen,
ssh-keyscan, sshd, sftp-server).
BTW, I just noticed that the attached patch is necessary (as a
supplement to my commit) to make dependency tracking work correctly.
DES
--
Dag-Erling Smorgrav - des@ofug.org
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=libnames.diff
Index: secure/Makefile.inc
===================================================================
RCS file: /home/ncvs/src/secure/Makefile.inc,v
retrieving revision 1.18
diff -u -r1.18 Makefile.inc
--- secure/Makefile.inc 28 Mar 2001 12:08:18 -0000 1.18
+++ secure/Makefile.inc 22 Jan 2002 22:11:10 -0000
@@ -21,9 +21,4 @@
.if !defined(NO_OPENSSH)
SSHDIR= ${.CURDIR}/../../../crypto/openssh
-.if exists(${.OBJDIR}/../../lib/libssh)
-LIBSSH= ${.OBJDIR}/../../lib/libssh/libssh.a
-.else
-LIBSSH= ${.CURDIR}/../../lib/libssh/libssh.a
-.endif
.endif
Index: share/mk/bsd.libnames.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.libnames.mk,v
retrieving revision 1.49
diff -u -r1.49 bsd.libnames.mk
--- share/mk/bsd.libnames.mk 21 Jan 2002 20:42:25 -0000 1.49
+++ share/mk/bsd.libnames.mk 22 Jan 2002 22:12:28 -0000
@@ -92,6 +92,7 @@
LIBROKEN?= ${DESTDIR}${LIBDIR}/libroken.a # XXX in secure dist, not base
LIBRPCSVC?= ${DESTDIR}${LIBDIR}/librpcsvc.a
LIBSBUF?= ${DESTDIR}${LIBDIR}/libsbuf.a
+LIBSSH?= ${DESTDIR}${LIBDIR}/libssh.a # XXX in secure dist, not base
LIBSMB?= ${DESTDIR}${LIBDIR}/libsmb.a
LIBSSL?= ${DESTDIR}${LIBDIR}/libssl.a # XXX in secure dist, not base
LIBSTDCPLUSPLUS?= ${DESTDIR}${LIBDIR}/libstdc++.a
--=-=-=--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpvgdukowf.fsf>