From owner-freebsd-bugs@FreeBSD.ORG Wed Jun 20 07:50:04 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0FBDB16A421 for ; Wed, 20 Jun 2007 07:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id E4C5813C465 for ; Wed, 20 Jun 2007 07:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5K7o3Ju055699 for ; Wed, 20 Jun 2007 07:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5K7o3VP055698; Wed, 20 Jun 2007 07:50:03 GMT (envelope-from gnats) Resent-Date: Wed, 20 Jun 2007 07:50:03 GMT Resent-Message-Id: <200706200750.l5K7o3VP055698@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, kabe@sra-tohoku.co.jp Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E2C116A468 for ; Wed, 20 Jun 2007 07:48:13 +0000 (UTC) (envelope-from sra01@nsfw.cis.iwate-u.ac.jp) Received: from nsfw.cis.iwate-u.ac.jp (nsfw.cis.iwate-u.ac.jp [160.29.192.249]) by mx1.freebsd.org (Postfix) with ESMTP id 9911313C468 for ; Wed, 20 Jun 2007 07:48:12 +0000 (UTC) (envelope-from sra01@nsfw.cis.iwate-u.ac.jp) Received: from nsfw.cis.iwate-u.ac.jp (localhost4 [127.0.0.1]) by nsfw.cis.iwate-u.ac.jp (8.13.8/8.13.8) with ESMTP id l5K7RXAB081586; Wed, 20 Jun 2007 16:27:33 +0900 (JST) (envelope-from sra01@nsfw.cis.iwate-u.ac.jp) Received: (from sra01@localhost) by nsfw.cis.iwate-u.ac.jp (8.13.8/8.13.8/Submit) id l5K7RWDi081585; Wed, 20 Jun 2007 16:27:32 +0900 (JST) (envelope-from sra01) Message-Id: <200706200727.l5K7RWDi081585@nsfw.cis.iwate-u.ac.jp> Date: Wed, 20 Jun 2007 16:27:32 +0900 (JST) From: kabe@sra-tohoku.co.jp To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: kabe@sra-tohoku.co.jp Subject: bin/113879: [ipf][patch] ipfstat -D, -S does not accept "any" as host address X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: kabe@sra-tohoku.co.jp List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2007 07:50:04 -0000 >Number: 113879 >Category: bin >Synopsis: [ipf][patch] ipfstat -D, -S does not accept "any" as host address >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 20 07:50:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Taketo Kabe >Release: FreeBSD 6.2-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD nsfw.cis 6.2-RELEASE-p5 FreeBSD 6.2-RELEASE-p5 #1: Fri May 25 14:45:23 JST 2007 root@core.cis:/usr/obj/var/src62/src/sys/GENERIC i386 >Description: ipfstat(8) is described to accept "any" as host address filter for -D and -S options i.e "-D any,", but didn't. Just adding "ok = 1;" in ipfstat.c to set the parsed flag fixes this. [This fix is not FreeBSD specific and should be submitted to ipfilter core also] >How-To-Repeat: # ipfstat -S any,any Invalid IP address: any >Fix: --- src/contrib/ipfilter/tools/ipfstat.c.dist Thu Aug 24 07:37:10 2006 +++ src/contrib/ipfilter/tools/ipfstat.c Wed Jun 20 06:54:57 2007 @@ -1567,7 +1567,7 @@ *port = -1; } else if (!sscanf(comma + 1, "%d", port) || (*port < 0) || (*port > 65535)) { - fprintf(stderr, "Invalid port specfication in %s\n", + fprintf(stderr, "Invalid port specification in %s\n", argument); free(s); exit(-2); @@ -1579,6 +1579,7 @@ /* get ip address */ if (!strcasecmp(s, "any")) { ip->in4.s_addr = INADDR_ANY; + ok = 1; #ifdef USE_INET6 ip->in6 = in6addr_any; } else if (use_inet6 && inet_pton(AF_INET6, s, &ip->in6)) { >Release-Note: >Audit-Trail: >Unformatted: