Date: Fri, 10 Sep 1999 01:20:01 -0700 (PDT) From: Jeremy Lea <reg@shale.csir.co.za> To: freebsd-ports@FreeBSD.org Subject: Re: ports/13677: Misc. Ports fix ups. Message-ID: <199909100820.BAA83999@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/13677; it has been noted by GNATS.
From: Jeremy Lea <reg@shale.csir.co.za>
To: Thomas Gellekum <tg@ihf.rwth-aachen.de>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/13677: Misc. Ports fix ups.
Date: Fri, 10 Sep 1999 01:15:34 -0700
Hi,
On Fri, Sep 10, 1999 at 10:02:58AM +0200, Thomas Gellekum wrote:
> reg@shale.csir.co.za writes:
>
> > Some things... python: this
> > fixes a problem which I had with threads support in py-gnome.
>
> > --- /usr/ports.ref/lang/python/Makefile Tue Aug 31 21:36:12 1999
> > +++ lang/python/Makefile Tue Aug 31 22:04:17 1999
> > @@ -52,7 +52,7 @@
> > LIBC_R!= /sbin/ldconfig -r | grep c_r || true
> > .if ${LIBC_R} != "" && defined(WITH_THREADS) && ${WITH_THREADS} == yes
> > CONFIGURE_ARGS+= --with-thread
> > -CFLAGS+= -D_THREAD_SAFE
> > +CFLAGS+= -D_THREAD_SAFE -pthread
> > CONFIGURE_ENV+= LDFLAGS="-pthread ${LDFLAGS}"
> > .endif
>
> Since -pthread is a linker flag, not a compiler flag, I'd prefer:
>
> Index: patches/patch-ab
> ===================================================================
> RCS file: /home/ncvs/ports/lang/python/patches/patch-ab,v
> retrieving revision 1.12
> diff -u -r1.12 patch-ab
> --- patch-ab 1999/05/10 16:11:45 1.12
> +++ patch-ab 1999/09/10 07:58:20
> @@ -1,11 +1,11 @@
> ---- configure.orig Mon May 10 23:49:46 1999
> -+++ configure Mon May 10 23:50:31 1999
> +--- configure.orig Sat Apr 10 18:02:18 1999
> ++++ configure Fri Sep 10 09:47:29 1999
> @@ -2246,7 +2246,7 @@
> fi ;;
> Linux*) LDSHARED="gcc -shared";;
> dgux*) LDSHARED="ld -G";;
> - FreeBSD*/3*) LDSHARED="gcc -shared";;
> -+ FreeBSD*/3*|FreeBSD*/4*) LDSHARED="gcc -shared";;
> ++ FreeBSD*/3*|FreeBSD*/4*) LDSHARED='gcc -shared ${LDFLAGS}';;
> FreeBSD*|OpenBSD*) LDSHARED="ld -Bshareable";;
> NetBSD*)
> if [ "`$CC -dM -E - </dev/null | grep __ELF__`" != "" ]
>
> Does this help you with py-gnome, whatever the problem is?
The problem was that python would hang during one or other phase of the
build of py-gnome. It was caused by being compiled with
'-D_THREAD_SAFE' but not being linked with '-pthread', since gcc not ld
was being used for linking, so the patch above would have the same
effect...
The problem might have only been temporary (it was on -CURRENT) and
might not happen with all the fixes in libc_r... But it's being
compiled with the wrong flags anyway, so it needs to be fixed.
Regards,
-Jeremy
--
| "Come home my prodigal son, come home and lets be one,
--+-- don't want to see you cry, don't make me tell you why,
| you've lived in a house with me, my blood has set you free,
| in the world you'll surely die, nothing else will satisfy." -MIC
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909100820.BAA83999>