From owner-svn-src-all@FreeBSD.ORG Tue Oct 28 15:30:51 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C55A106567F; Tue, 28 Oct 2008 15:30:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3B8AF8FC19; Tue, 28 Oct 2008 15:30:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id m9SFUCWl024647; Tue, 28 Oct 2008 11:30:45 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Peter Wemm Date: Tue, 28 Oct 2008 10:22:41 -0400 User-Agent: KMail/1.9.7 References: <200810280326.m9S3QPit080877@svn.freebsd.org> In-Reply-To: <200810280326.m9S3QPit080877@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810281022.41296.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 28 Oct 2008 11:30:45 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8526/Tue Oct 28 09:21:35 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184385 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2008 15:30:51 -0000 On Monday 27 October 2008 11:26:25 pm Peter Wemm wrote: > Author: peter > Date: Tue Oct 28 03:26:25 2008 > New Revision: 184385 > URL: http://svn.freebsd.org/changeset/base/184385 > > Log: > After a machine has been up for a bit more than 20 days with HZ=1000, > "ticks" goes negative. This breaks the signed comparison in softclock. > This causes sleep() to never wake up, tcp to stop, etc etc. This is > bad(TM). Use the SEQ_LT() method from tcp's sequence number comparisons. > > Modified: > head/sys/kern/kern_timeout.c I wonder why this used < rather than the != that older branches used. -- John Baldwin