From owner-freebsd-current@freebsd.org Thu May 19 02:05:18 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AADC2B3FF37 for ; Thu, 19 May 2016 02:05:18 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: from mail-oi0-x231.google.com (mail-oi0-x231.google.com [IPv6:2607:f8b0:4003:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D9731283 for ; Thu, 19 May 2016 02:05:18 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: by mail-oi0-x231.google.com with SMTP id x19so106712973oix.2 for ; Wed, 18 May 2016 19:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=capeaugusta-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=+E9DAOv/lOCNGqvipXvnEzzZ61e/pCDsOma0mHrrO/8=; b=LOA9MYxBgSLq0JdKWeLU1P3d4k7aEb38hXBEwNh68ICBbhSlw9+C5seQyW0mxiJ8Mj aQiuHoBpRI/1PgrsEYsNKZ8ZN6RxPa288ybQV9XFCHen3rqhh2p7v+PDfK3YbA+gGK3H 6PMjYybOzQr+PBdbd5rBt5iGU0hoCMZIVjNhoNepQDciN5kneHGKa1b4D3B70dNWtwO/ SYGTLRFl1kv4fESJ0qLcbfOOOJ89PWOxL6MunCv/8q3U7y7ycEJU6026eHbjRF82HpnO xJCtihQh/qxm+KweL/SFB8ORxI3tm3Cr6N0kkL+RCIZHBcCC+wNWIcqg9CEBqxLYFAir wGfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=+E9DAOv/lOCNGqvipXvnEzzZ61e/pCDsOma0mHrrO/8=; b=EfWrnrAU+AWx3AGWwCRhRr6whvtFRcxTVF8/mbfQIjrDSWZWY8zbE4/aUI1WQ4R8RM 5j/PdhiCtcr1uHVuIstStLJLdrVBwiU+99p5IdJv3fgDKtGi8sPlH8MQT1jc5+/irVZu NWedjOxt1D9uvxZpPYvA1aEsq4Ixv4kJZ9a/cfMMNe5vVqU3VVu115EDqbT2BnqlguuD EWoD5l9xN9FdMh/fwkyejx1BVwzILuIg1k5Of2MI3FgOS/BxpBL59+79KGP/frPV4zMC x9+5pMJ7Q33Dacuhvqa4KWODwEAhXD5euAKFbomimheReouQHWtjRa6gEPhE4VDuPYc9 V4Sw== X-Gm-Message-State: AOPr4FW9MCKM8OUDLibSjYDPxYNhYzi3oYMW68Nrza4tBi+QdkPDvmon42EjEDbvoIKjiU0keQceyuhCzftPL7o3ajnDog8kQBbtyC2/j8oglmUWw+mGOmnaT6Y50YCvoCJcLsqHErfcCGGsvqpBcqougc2ED2azY7NYAt7TIbhzYDNhwtHO8ENLOqQtxPNoPDmqOuRmFUC6 X-Received: by 10.202.69.134 with SMTP id s128mr6282057oia.97.1463623517769; Wed, 18 May 2016 19:05:17 -0700 (PDT) Received: from zen.clue.co.za (c-71-226-15-200.hsd1.ga.comcast.net. [71.226.15.200]) by smtp.gmail.com with ESMTPSA id o17sm3285466oto.0.2016.05.18.19.05.17 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 May 2016 19:05:17 -0700 (PDT) Subject: Re: r299512 breaks dhclient on some networks To: freebsd-current@freebsd.org References: <201605190019.u4J0JFXN080729@gw.catspoiler.org> From: Ian FREISLICH Message-ID: Date: Wed, 18 May 2016 22:05:16 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <201605190019.u4J0JFXN080729@gw.catspoiler.org> Content-Type: text/plain; charset=windows-1252 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 02:05:18 -0000 On 05/18/16 20:19, Don Lewis wrote > It looks to me like r299512 is changing the format of the client > identifier by inserting the struct hardware hlen field into it. That's > not valid if htype is non-zero the way I interpret RFC 2132. On the > other hand, I would think that the server would interpret the client ID > as an opaque cookie, so I wouldn't think it would make a difference > (other than thinking this is a new client) unless your server is > configured to look for specific client IDs. It's not that the server isn't working. The client is discarding the server's offer for whatever reason. But, r300174 has it working again for me. I can't speak to the correctness of the fix though. Ian -- Ian Freislich -- Cape Augusta Digital Properties, LLC a Cape Augusta Company *Breach of confidentiality & accidental breach of confidentiality * This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.