From owner-freebsd-net  Tue Jun 20 12: 5:53 2000
Delivered-To: freebsd-net@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP id 9E84E37BFCD
	for <freebsd-net@FreeBSD.ORG>; Tue, 20 Jun 2000 12:05:49 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.2) id MAA26374;
	Tue, 20 Jun 2000 12:05:13 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200006201905.MAA26374@bubba.whistle.com>
Subject: Re: Patch review request (ng_ether(4))
In-Reply-To: <3938AA5E.15FB7483@elischer.org> from Julian Elischer at "Jun 2, 2000 11:49:02 pm"
To: julian@elischer.org (Julian Elischer)
Date: Tue, 20 Jun 2000 12:05:13 -0700 (PDT)
Cc: freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Julian Elischer writes:
> > > > > As soon as I can access freefall again I'll put up a new patch.
> > > >
> > > > OK, try this one:
> > > >
> > > >   ftp://ftp.whistle.com/pub/archie/misc/NGETHER.patch.2
> > >
> > > you need to block attaches to orphan if the lower hook is in use,
> > > and visa versa.
> > 
> > It should already do that.. they both use priv->lower.
> 
> OK
> 
> comment in ng_ether_input_orphan() is wrong.
> 
> You can't use NG_SEND_DATA_RET() in an ethernet driver (on input)
> because you need to use NG_QUEUE_DATA()   (splimp, remember)
> My thought is that you would supply a separate hook for 
> 'FILTER' operations which you would warn would have to 
> be run at splimp. The splnet and splimp graphs can only be joined
> by queueing links (going up). I think this needs work, and there 
> is a possibility that we could put transfer characteristics 
> as a property on links so that the right thing happens.

OK, back from vacation :-)

Here's a new patch addressing the above problem:

  ftp://ftp.whistle.com/pub/archie/misc/NGETHER.patch.3

> The FILTER hooks would either have to be attached
> to nodes that use NG_QUEUE_DATA(), or which
> had no connection to the splnet universe. Automatic registration
> of spl levels on hooks might lead to some automatic  handling
> of this but 
> a/ I think the programmer should know what is going on.
> b/ this may all become moot with the removal of SPLs for 
>     interrupts.

I vote for option (b) :-)

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message