From owner-svn-src-head@FreeBSD.ORG Thu Nov 28 07:39:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 222AFB91 for ; Thu, 28 Nov 2013 07:39:26 +0000 (UTC) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C7D71AC4 for ; Thu, 28 Nov 2013 07:39:25 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id hp15so3994700lab.27 for ; Wed, 27 Nov 2013 23:39:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=WMkjAgP1XYCwMkun7AjO+P5TcCowx90lWdGDrKLnGnI=; b=fJAudCFT/6Ut3FZje/GiC7UFhneDeFWR/mqLaycHhoq4o8gXPbP9CSeGKyYrlv0iaV wsR+RmPtfAWc0/dhsPo2l0WXzjaSbkubjqeGqiQsngHa3XrMcz4dc0JCF0kH/7AJcZv/ bnyrFUzPjXdLJpSCuf0IlL2z2C2dVkIi6QHUZstEwMQCEu8MVv+qrt0KEEHUcjGfxvsK brj9HD/9jvJP3aA0mnNQ3MBdMg5BSuxyVTnTkOOyvvJyL9AHrIslznYG9LEvHWiGHt65 NlCRzPdHfZS9e94hb+0g71AOk5GSQNk6AwWreOO2F7sF1acPBZicV9Fu1vMON3m4o2ld llCQ== X-Gm-Message-State: ALoCoQmwXZPvQfIENjR8xngC6CW1dFoqoTbDzrbQlPotlBVgpdTPgK8tbiSeJjGQ8PkXC8Bq3nQY X-Received: by 10.152.28.230 with SMTP id e6mr26427228lah.3.1385624363230; Wed, 27 Nov 2013 23:39:23 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.234.12 with HTTP; Wed, 27 Nov 2013 23:39:02 -0800 (PST) In-Reply-To: <20131128070003.GY90895@FreeBSD.org> References: <201311271759.rARHxEPE069195@svn.freebsd.org> <20131128070003.GY90895@FreeBSD.org> From: Juli Mallett Date: Wed, 27 Nov 2013 23:39:02 -0800 X-Google-Sender-Auth: g6o0NvG9wyJZHOJmYEWPN7ChsHE Message-ID: Subject: Re: svn commit: r258686 - head/sbin/fdisk To: Gleb Smirnoff Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 07:39:26 -0000 On Wed, Nov 27, 2013 at 11:00 PM, Gleb Smirnoff wrote: > Juli, > > On Wed, Nov 27, 2013 at 05:59:14PM +0000, Juli Mallett wrote: > J> Author: jmallett > J> Date: Wed Nov 27 17:59:13 2013 > J> New Revision: 258686 > J> URL: http://svnweb.freebsd.org/changeset/base/258686 > J> > J> Log: > J> Fix fdisk(8) to create 2TB partitions on disks larger than 2TB, > rather than > J> only being able to create 1TB partitions: > J> o) Use an unsigned 32-bit quantity to store the number of disk > sectors. > J> o) Detect overflow of said 32-bit quantity and clamp to 2^32. > J> o) Rather than returning the disk sector count from get_params, > return 0 on > J> success, since its return value is only ever compared to -1 to > detect > J> failure. This would cause returning 2^32 sectors to be > interpreted as an > J> error. > J> > J> Reviewed by: bde ("good for a quick fix") > > What is the reason to use fdisk today, instead of gpart? > Habit? Hysterical reasons? Ease-of-use? (The fact that I find fdisk(8) easier to use than gpart(8) is probably a bug in me and not in gpart(8), but it always takes me too many steps to get things done with gpart(8), including some manpage reading.) Being fairly self-contained so that one can use it in automated systems without worrying about which geom(4) modules are in the host system's kernel is probably the most-reasonable version. If it's so deprecated that leaving bugs in it is desirable, please remove it from the tree entirely :) Thanks, Juli.