From owner-svn-ports-head@freebsd.org Tue Nov 24 12:20:30 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17A6BA35218; Tue, 24 Nov 2015 12:20:30 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F2091E00; Tue, 24 Nov 2015 12:20:29 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmvv187 with SMTP id v187so206476015wmv.1; Tue, 24 Nov 2015 04:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=736Dwyf9fnGYjNP3GX+0GLGb+D2Pg2NM1FYBSR9oFBs=; b=vxkAazkZQGDmzK6mQuJACcKOYQ5AGWRiHvHW6oi489/4HnrAMQbjfP1UjGgsXJjXcC 9pI7j0BT++OYa+/u7ScrojTsgAOustup9yoYMjtQN+H2RP6PNIxAyfd6cmbwBz8sCSxq Yb1uI0s+/ZH6eugC4qZg2h1ZeoNDfzMvD4wKlSrQqBjnVvgvyJNG3AAh5akTKmWc3WES OdoGsv+R/V6SWynsX+YiAX8JalVyGRJdIJDaFZHNG8SFkel62L2Bzy70hzrnPEJpPZD7 TzhZnzdI4UoSQsUyM1MPSPDf8RK5lPsgwxzBOn0GEPPeyJrGxvJahhUHZ5t51cv/xpX6 2PFw== X-Received: by 10.194.121.7 with SMTP id lg7mr18703844wjb.90.1448367628154; Tue, 24 Nov 2015 04:20:28 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id jt9sm18089324wjc.24.2015.11.24.04.20.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Nov 2015 04:20:27 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 24 Nov 2015 13:20:25 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: marino@freebsd.org, Gerald Pfeifer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r402352 - head/lang/gcc Message-ID: <20151124122024.GD76516@ivaldir.etoilebsd.net> References: <201511241019.tAOAJMTF049917@repo.freebsd.org> <20151124110152.GA78748@FreeBSD.org> <5654459E.40100@marino.st> <20151124115156.GA3457@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hoZxPH4CaxYzWscb" Content-Disposition: inline In-Reply-To: <20151124115156.GA3457@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 12:20:30 -0000 --hoZxPH4CaxYzWscb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 24, 2015 at 11:51:56AM +0000, Alexey Dokuchaev wrote: > On Tue, Nov 24, 2015 at 12:10:22PM +0100, John Marino wrote: > > On 11/24/2015 12:01 PM, Alexey Dokuchaev wrote: > > > On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote: > > >> Author: gerald > > >> URL: https://svnweb.freebsd.org/changeset/ports/402352 > > >> > > >> [...] > > >> @@ -168,5 +168,10 @@ post-stage: > > >> fi > > >> .endfor > > >> cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST} > > >> + # This is the canonical GCC port, so add key commands without > > >> + # version numbers as part of their names. > > >=20 > > > Comment is badly indented (will be executed as part of the target rec= ipe). > >=20 > > Are you sure? I thought that only applies to legacy make, not bmake. >=20 > Hmm, indeed. >=20 > But even if bmake is smart enough to skip shell comments, it still looks > like part of the recipe, which is not very neat. >=20 And legacy make is still used on 9.x Bapt --hoZxPH4CaxYzWscb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZUVggACgkQ8kTtMUmk6EzVwQCfQi2CHa7go3zmaTuLcs2tKzZR Og8AoLIQUhmKKU+Jtx0wC4vo73kW8tL1 =Zdid -----END PGP SIGNATURE----- --hoZxPH4CaxYzWscb--