From owner-cvs-all  Tue Apr  9 18:42:57 2002
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 869AF37B42A; Tue,  9 Apr 2002 18:42:44 -0700 (PDT)
Received: (from brian@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g3A1giH06544;
	Tue, 9 Apr 2002 18:42:44 -0700 (PDT)
	(envelope-from brian)
Message-Id: <200204100142.g3A1giH06544@freefall.freebsd.org>
From: Brian Somers <brian@FreeBSD.org>
Date: Tue, 9 Apr 2002 18:42:44 -0700 (PDT)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/netinet in.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

brian       2002/04/09 18:42:44 PDT

  Modified files:
    sys/netinet          in.c 
  Log:
  Remove the code that masks an EEXIST returned from rtinit() when
  calling ioctl(SIOC[AS]IFADDR).
  
  This allows the following:
  
    ifconfig xx0 inet 1.2.3.1 netmask 0xffffff00
    ifconfig xx0 inet 1.2.3.17 netmask 0xfffffff0 alias
    ifconfig xx0 inet 1.2.3.25 netmask 0xfffffff8 alias
    ifconfig xx0 inet 1.2.3.26 netmask 0xffffffff alias
  
  but would (given the above) reject this:
  
    ifconfig xx0 inet 1.2.3.27 netmask 0xfffffff8 alias
  
  due to the conflicting netmasks.  I would assert that it's wrong
  to mask the EEXIST returned from rtinit() as in the above scenario, the
  deletion of the 1.2.3.25 address will leave the 1.2.3.27 address
  as unroutable as it was in the first place.
  
  Offered for review on: -arch, -net
  Discussed with: stephen macmanus <stephenm@bayarea.net>
  MFC after: 3 weeks
  
  Revision  Changes    Path
  1.65      +0 -4      src/sys/netinet/in.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message