From owner-freebsd-bugs@FreeBSD.ORG Tue May 19 03:34:55 2015 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB1FA447 for ; Tue, 19 May 2015 03:34:55 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AFB61FB7 for ; Tue, 19 May 2015 03:34:55 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4J3YtgC029755 for ; Tue, 19 May 2015 03:34:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 200316] don't have compiler inline vdev_queue_max_async_writes so zfs write throttle tuning works Date: Tue, 19 May 2015 03:34:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lacey.leanne@gmail.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 03:34:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200316 Bug ID: 200316 Summary: don't have compiler inline vdev_queue_max_async_writes so zfs write throttle tuning works Product: Base System Version: 10.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: lacey.leanne@gmail.com Created attachment 156921 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D156921&action= =3Dedit patch against 10.1-RELEASE to fix the issue. On unpatched systems vdev_queue_max_async_writes is inlined and hidden from dtrace.=20 This prevents the use of the q.d async write tuning script, as outlined here http://dtrace.org/blogs/ahl/2014/08/31/openzfs-tuning/ which makes it difficult to properly investigate and tune the ZFS write throttle on FreeBSD 10.1.=20 On unpatched systems the script reports: dtrace: failed to compile script ./q.d: line 6: probe description fbt::vdev_queue_max_async_writes:entry does not match any probes Once patched, the output looks like this: min .--------------------------------. max | count < 0 : =E2=96=88 : >=3D 30 | 174 min .--------------------------------. max | count < 0 : : >=3D 30 | 0 The attached patch adding __noinline fixes this.=20 The problem can be reproduced on unpatched systems with the attached q.d script. Thank you for your time and assistance in fixing this. --=20 You are receiving this mail because: You are the assignee for the bug.=