From owner-freebsd-wireless@FreeBSD.ORG Sat Dec 3 14:00:25 2011 Return-Path: Delivered-To: freebsd-wireless@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58143106564A for ; Sat, 3 Dec 2011 14:00:25 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3F2C68FC13 for ; Sat, 3 Dec 2011 14:00:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB3E0PPI001107 for ; Sat, 3 Dec 2011 14:00:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB3E0PfU001105; Sat, 3 Dec 2011 14:00:25 GMT (envelope-from gnats) Date: Sat, 3 Dec 2011 14:00:25 GMT Message-Id: <201112031400.pB3E0PfU001105@freefall.freebsd.org> To: freebsd-wireless@FreeBSD.org From: Alexander Best Cc: Subject: Re: kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alexander Best List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2011 14:00:25 -0000 The following reply was made to PR kern/162475; it has been noted by GNATS. From: Alexander Best To: bug-followup@freebsd.org Cc: Subject: Re: kern/162475: [ath] functions with return type HAL_BOOL (might) return HAL_STATUS Date: Sat, 3 Dec 2011 13:55:34 +0000 here are two more examples: /usr/subversion-src/sys/dev/an/if_an.c:800:41: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion] mword = ieee80211_rate2media(NULL, r, IEEE80211_T_DS); ~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~ /usr/subversion-src/sys/dev/an/if_an.c:3302:30: warning: implicit conversion from enumeration type 'enum ieee80211_phytype' to different enumeration type 'enum ieee80211_phymode' [-Wconversion] status.an_current_tx_rate, IEEE80211_T_DS); ^~~~~~~~~~~~~~ 2 warnings generated. ..also fixing these would make the entire kernel code "-Wconversion"-clean, i believe. cheers. alex