From owner-svn-ports-head@FreeBSD.ORG Mon Dec 17 20:06:05 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4D0E62FF; Mon, 17 Dec 2012 20:06:05 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by mx1.freebsd.org (Postfix) with ESMTP id 55CAA8FC14; Mon, 17 Dec 2012 20:06:04 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id 12so2785845wgh.31 for ; Mon, 17 Dec 2012 12:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=/QOOM5dycQ7NW29jwiUL76HQT0+x34KdHVUzwCMN2ws=; b=pdJtKa++8Z5bPAv9i4TdGneFy9r5HWJmTd/ngajr4NPQUxFkaTIvoXjTvcPaxMx/4/ NehuGyfWAbkfEJ/3+Jz9GvREF0ZpJJYX2ebmJoAKk4BwyZQJOVdsaSZHjvBVTcRZrElg rVkdW4ciYpntwd1hepID6u35Jse72j1Nwd5P1qJkae3lVyRoROfsxgiD6wC+i2Tvua3E NqjPx0fTDuxRqeywXFgK2nLf3ZMKBluMRv2h8adUQa8Z5pyJDAvI6tOvKdAkILunJ5ZW hyvyCMH23cMjqJ1ih4RqZWGdcwfhwM1tDP2SMOJVQddOCLRsETAEyv5Hw34YlbTLK1pM c/lA== Received: by 10.194.173.195 with SMTP id bm3mr19320005wjc.32.1355774761799; Mon, 17 Dec 2012 12:06:01 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id cf6sm14146548wib.3.2012.12.17.12.06.01 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Dec 2012 12:06:01 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 17 Dec 2012 21:05:59 +0100 From: Baptiste Daroussin To: Wesley Shields Subject: Re: svn commit: r309126 - head/audio/aumix Message-ID: <20121217200559.GB68303@ithaqua.etoilebsd.net> References: <201212172002.qBHK2Bwf057818@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline In-Reply-To: <201212172002.qBHK2Bwf057818@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 20:06:05 -0000 --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 17, 2012 at 08:02:11PM +0000, Wesley Shields wrote: > Author: wxs > Date: Mon Dec 17 20:02:10 2012 > New Revision: 309126 > URL: http://svnweb.freebsd.org/changeset/ports/309126 >=20 > Log: > Convert to new options. > =20 > PR: ports/173783 > Submitted by: Chris Petrik > Approved by: maintainer timeout >=20 > Modified: > head/audio/aumix/Makefile (contents, props changed) >=20 > Modified: head/audio/aumix/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/audio/aumix/Makefile Mon Dec 17 20:00:53 2012 (r309125) > +++ head/audio/aumix/Makefile Mon Dec 17 20:02:10 2012 (r309126) > @@ -1,9 +1,5 @@ > -# New ports collection makefile for: aumix > -# Date created: 21 May 1999 > -# Whom: Chris Piazza > -# > +# Created by: Chris Piazza > # $FreeBSD$ > -# > =20 > PORTNAME=3D aumix > PORTVERSION=3D 2.9.1 > @@ -34,11 +30,12 @@ PLIST_FILES=3D bin/aumix bin/mute bin/xaum > PLIST_FILES+=3D share/aumix/${ii} > .endfor > =20 > -OPTIONS=3D NLS "Enable NLS support" on \ > - GTK2 "Enable GTK2 gui" off > +.include > =20 > -.include > -.if defined(WITHOUT_NLS) > +OPTIONS_DEFINE=3D NLS GTK2 > +OPTIONS_DEFAULT=3D NLS > + This is wrong The include should be here, OPTIONS_DEFINE and friends should always be def= ined prior to any bsd.port.options.mk include or bsd.port.pre.mk include While here, OPTIONS_DEFAULT=3D NLS is useless the framework takes care of s= etting NLS on by default regards, Bapt --kORqDWCi7qDJ0mEj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDPeycACgkQ8kTtMUmk6ExRWgCffCRAbU4V0C4JrdS6CgHsGVe/ OpMAn0vBo5/C0Pfsd4YDbYAPmeSvLGBf =17ps -----END PGP SIGNATURE----- --kORqDWCi7qDJ0mEj--