From owner-svn-src-all@freebsd.org Tue Dec 4 18:13:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D40D31315819; Tue, 4 Dec 2018 18:13:48 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 63A6E871A6; Tue, 4 Dec 2018 18:13:46 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id wB4IDhtg037434; Tue, 4 Dec 2018 10:13:43 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id wB4IDhd1037433; Tue, 4 Dec 2018 10:13:43 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201812041813.wB4IDhd1037433@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r341464 - head/sbin/savecore In-Reply-To: To: Xin LI Date: Tue, 4 Dec 2018 10:13:43 -0800 (PST) CC: rgrimes@freebsd.org, Renato Botelho do Couto , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 63A6E871A6 X-Spamd-Result: default: False [-1.08 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.60)[-0.604,0]; IP_SCORE(-0.02)[country: US(-0.09)]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; NEURAL_HAM_LONG(-0.53)[-0.526,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; NEURAL_HAM_SHORT(-0.82)[-0.822,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; FORGED_RECIPIENTS(0.00)[delphij@gmail.com ..,src-committers@freebsd.org ...]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 18:13:49 -0000 > On Tue, Dec 4, 2018 at 9:28 AM Rodney W. Grimes > > > > > Author: garga (ports committer) > > > Date: Tue Dec 4 12:34:22 2018 > > > New Revision: 341464 > > > URL: https://svnweb.freebsd.org/changeset/base/341464 > > > > > > Log: > > > Restore /var/crash permissions to 0750, as declared in mtree file. After > > > r337337 it changed to 0755. > > > > > > Reviewed by: loos > > > Approved by: loos > > > MFC after: 3 days > > > Sponsored by: Rubicon Communications, LLC (Netgate) > > > Differential Revision: https://reviews.freebsd.org/D18355 > > > > This probably warrants an EN against 12.0 release. > > Can we just fix it before 12.0-RELEASE builds starts? It would be > much more robust compared to delivering a "fixit" script though > freebsd-update... Thats Glens call, but normal procedure is 0 change between last RC and release. (Bcc:'ed to gjb@, and trimmed a bit) Rod > > > +++ head/sbin/savecore/Makefile Tue Dec 4 12:34:22 2018 (r341464) > > > @@ -2,7 +2,9 @@ > > > > > > PACKAGE=runtime > > > CONFS= minfree > > > -CONFSDIR= /var/crash > > > +VAR_CRASH= /var/crash > > > +VAR_CRASH_MODE= 0750 > > > +CONFSDIR= VAR_CRASH > > > PROG= savecore > > > LIBADD= z xo > > > MAN= savecore.8 -- Rod Grimes rgrimes@freebsd.org