From owner-dev-commits-src-all@freebsd.org Wed Jan 27 19:59:23 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C39074E7BF6 for ; Wed, 27 Jan 2021 19:59:23 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQvZM50JNz3HS6 for ; Wed, 27 Jan 2021 19:59:23 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f52.google.com with SMTP id f16so2503641wmq.5 for ; Wed, 27 Jan 2021 11:59:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=URJ0yPQQ+FTBhe2a50AICYBIGicsGBXVWDP08AZXEYs=; b=XuTbbw39qEOxxp3QGos1bUkr15pDuhRZ3+KVvdgWiwhj7JGqD8PDLXPka6DV/WU0FJ ONml0jXYZOnQ61l3u0HqozOf0TRmQlJcojmQBLZMaiL0FMMP05Yq1EmMj/uwXqHqkDp0 FmX4Mda9mNEpf++oqILZttABuH2vF00IRfKwN/1mYbFn4DsKgenO3RmwBx2HdsJQBRk8 ib8rlzk7Egrolq0HpVvdeB4yRoS1bJihU2TnRDgFObCkfMotjPPUTDXXGnCkCfV6re2W AEsdc7q8ACwbSpgqkDu5RtZusIGgpd0vkJsLfSYEJEI8D9KuQCffN4kxET7IoqifAd3c RWig== X-Gm-Message-State: AOAM530E5SiPro7HFlkKVRZfyYSjGF3Jc5lNoLIQsKm73yFB4NFlYG8F TZP60i/iUeCOWdCGZT11x6d4xg== X-Google-Smtp-Source: ABdhPJw0topqsRF0CoSjzbP623IIuMbBgLOixbvXspI2TpY20DzNk9eOPhEizmb2rwZrJVFSgPOj0w== X-Received: by 2002:a1c:cc19:: with SMTP id h25mr5601230wmb.124.1611777561927; Wed, 27 Jan 2021 11:59:21 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id h15sm4144995wrt.10.2021.01.27.11.59.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2021 11:59:21 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support From: Jessica Clarke In-Reply-To: Date: Wed, 27 Jan 2021 19:59:19 +0000 Cc: Kyle Evans , Lutz Donnerhacke , Lutz Donnerhacke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <76B5E43D-EB93-4739-BDD1-BECA4340CCDC@freebsd.org> References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org> <20210124194640.GA6527@belenus.iks-jena.de> To: John Baldwin X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DQvZM50JNz3HS6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 19:59:23 -0000 On 27 Jan 2021, at 19:55, John Baldwin wrote: > On 1/24/21 11:51 AM, Kyle Evans wrote: >> On Sun, Jan 24, 2021 at 1:47 PM Lutz Donnerhacke = wrote: >> We switched up the recommendations[0][1] to advocate for what you've >> done here ~2 weeks ago -- so yes, this is good. :-) >=20 > Note that "Submitted by" may still be needed when there are multiple > authors who contribute to a patch. (And I do kind of think pulling > it from the template was a bit hasty as it didn't take those cases > into account.) I do think we want Author to reflect the primary > author of the change though. The git world (or at least the GitHub world) seems to be settling in Co-authored-by: for that, which is more accurate. Jess