From owner-svn-src-all@freebsd.org Tue Sep 22 20:58:10 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E1A63F687B; Tue, 22 Sep 2020 20:58:10 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bwttn3S4Yz4cp3; Tue, 22 Sep 2020 20:58:09 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f177.google.com with SMTP id v23so15357605ljd.1; Tue, 22 Sep 2020 13:58:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xXfwgqyGssYX/b2CRh+NwCOG0+Z+0X2hU/aPgChW8Hw=; b=JTV0ZsfYz8BRhacJv/CuLtbJwFJpIscT6VMfQKXNuo4OEXRFfiBv3eqwjv1QC6r5Ru c2fQPaI3FwcC69X/sNqLUg6EuctGOuhcn/hP181psRNeik4rL5e5RA6A5hK+fdUoLPGw Qywv4Ad3DVZQFhjim882TGymzPT+y89pFslbyqRW4NA5WEB4QuWkLfE6u1chD0ch91Qy xi/E7hl4oKj2wKFg6Uz2t0ywcr05cDkXSIfDDrpqJQ4oASlrloXbgJbxBSQkwZMxkG5u 8bTq0r4aurDgqADCqF6bC7f0n99ibk+0iD7aDYMK10OikPf5ukovOjYMdh3oNE6Ib6d+ WRCQ== X-Gm-Message-State: AOAM5338T6LMjz+r+jDUZNAzJbPb7++d1p7PR4qX3HPP3vIjg+NeK2sQ fDfyNefw2AJALEazROCCw/Y84i+z/6bES7aFO+QGQwRrbqg= X-Google-Smtp-Source: ABdhPJxz+S1ihqfcJTHzFzfafntBjPUYCdMw0b3vMV39HUYxcdsK+gi3Pi9nSt+OqCZuNbkmb+KwYvqgV10vBMy+6mQ= X-Received: by 2002:a2e:9b99:: with SMTP id z25mr2298693lji.403.1600808287710; Tue, 22 Sep 2020 13:58:07 -0700 (PDT) MIME-Version: 1.0 References: <202009112049.08BKnavL032212@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 22 Sep 2020 14:57:56 -0600 Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Mateusz Guzik Cc: Kyle Evans , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4Bwttn3S4Yz4cp3 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-1.82 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.02)[-1.019]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.79)[-0.793]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.01)[-0.011]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.177:from]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.177:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 20:58:10 -0000 Looks like two places in stand. Is there any reason why Mateusz's suggestion wouldn't work? > rg -g Makefile 'cp.*/dev/null' stand/libsa/Makefile 125: [ -f xlocale/$$i ] || cp /dev/null xlocale/$$i; \ stand/i386/zfsboot/Makefile 82: cp /dev/null ${.TARGET} On Tue, Sep 22, 2020 at 2:54 PM Mateusz Guzik wrote: > Can we instead add a workaround to the build tree? > > Where is cp /dev/null coming from anyway? Perhaps this can be patched > to touch the target file. > > On 9/22/20, Alan Somers wrote: > > On Tue, Sep 22, 2020 at 2:48 PM Kyle Evans wrote: > > > >> On Fri, Sep 11, 2020 at 3:49 PM Alan Somers > wrote: > >> > > >> > Author: asomers > >> > Date: Fri Sep 11 20:49:36 2020 > >> > New Revision: 365643 > >> > URL: https://svnweb.freebsd.org/changeset/base/365643 > >> > > >> > Log: > >> > cp: fall back to read/write if copy_file_range fails > >> > > >> > Even though copy_file_range has a file-system agnostic version, it > >> still > >> > fails on devfs (perhaps because the file descriptor is > non-seekable?) > >> In > >> > that case, fallback to old-fashioned read/write. Fixes > >> > "cp /dev/null /tmp/null" > >> > > >> > >> Hi, > >> > >> Any objection to adding a quick UPDATING entry for this? I'm seeing > >> occasional reports of this breakage as recent as today on IRC from > >> folks that were a little bit thrown off by this because it throws up > >> fairly far into the build and looks like a stand build regression > >> instead of a cp regression. > >> > >> Thanks, > >> > >> Kyle Evans > >> > > > > No objection. Can you suggest the proper wording? > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > > > > -- > Mateusz Guzik >