From owner-freebsd-java@FreeBSD.ORG Tue Dec 20 23:06:01 2011 Return-Path: Delivered-To: freebsd-java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 170CF106566B; Tue, 20 Dec 2011 23:06:01 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0B7568FC0A; Tue, 20 Dec 2011 23:05:59 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id BAA09435; Wed, 21 Dec 2011 01:05:57 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Rd8kv-000JiC-5C; Wed, 21 Dec 2011 01:05:57 +0200 Message-ID: <4EF114D2.3010101@FreeBSD.org> Date: Wed, 21 Dec 2011 01:05:54 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111206 Thunderbird/8.0 MIME-Version: 1.0 To: Jason Helfman References: <201112201750.pBKHoD7P060916@freefall.freebsd.org> <20111220192549.GA58911@dormouse.experts-exchange.com> In-Reply-To: <20111220192549.GA58911@dormouse.experts-exchange.com> X-Enigmail-Version: undefined Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jilles Tjoelker , freebsd-java@FreeBSD.org Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open timezone data (tzdata) X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 23:06:01 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 on 20/12/2011 21:25 Jason Helfman said the following: > On Tue, Dec 20, 2011 at 05:50:13PM +0000, Greg Lewis thus spake: >> Thanks for doing this! I wonder if with a little more work we couldn't >> make this work for all of the JDK ports instead of having to reimplement >> it for openjdk7, jdk16, jdk15, diablo, etc. > > Yeah, I suppose this could be done, and sounds fitting. I haven't > researched it enough for all jdk implementations, however it going into > openjdk{6,7}, at a minimum is a good start, in my opinion, until a more > lucrative method is found. I couldn't believe that the timezone data hasn't > been updated in openjdk6 since 2010, and I believe supplying at least > updated zoneinfo is something we should consider. > >> I.e., can we pull this out into a separate port that installs the >> appropriate zoneinfo files into somewhere like >> ${LOCALBASE}/share/java/zoneinfo and then symlink the zi directory in >> all of the jdk and jre ports to that directory. > > Installation of the zoneinfo files isn't the key, though. It is the raw > timezone files that are required so java can build against them. But if > those were built against then installed for java, that could work. I think that "java building against the raw files" really means converting those files to some private java format and installing those converted files along with jdk/jre. >> I haven't looked deeply into your change but I assume the biggest >> problem with this is that you need a JDK with javazic.jar already >> installed before you can process the raw zoneinfo files so we'd be >> creating a circular dependency. > > You don't need it installed. You can use the tool at build-time. My patch > uses the ${WRKSRC} built bin/java and javazic.jar tool to build the zone > files. It puts them into their new working directory, and they are > installed with the install target. You don't need it installed if the building of java timezone files is done within a jdk port. OTOH, if java timezone data lives in a separate port, then it needs to be updatable independently and thus it needs some tools for the zoneinfo -> java tz conversion. E.g. please see some earlier deliberations on this topic which never came to fruition: http://article.gmane.org/gmane.os.freebsd.devel.java/11756 http://article.gmane.org/gmane.os.freebsd.devel.java/11638 Now that you have this thing going I hope that you would be interested to implement it as close to perfection as possible :-) Even if not, then what you already have is much better that the status quo. Thank you. P.S. Just noticed Jilles' followup, could have saved myself some typing :) But since this is already written then I am just hitting Send. - -- Andriy Gapon -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO8RTSAAoJEHSlLSemUf4v3kgIAIU2OYbWixecMhc7ps7lyXsp m2/84MCJHZ4Ro35LjaOM3jnYoLWudAYMTYV/fYts5jzmreGUmNTen4nJKfd5EktY pnxtVlSbBMkTaeDbYT/VVfjf4wLOEsCBc1yxiVjuGVsUTLsfU3VK/HPB5AHklVn3 zlQS6HYKPpmsQupt7MztCxaU1LeEPk+Gbft8oJmg8KdHa+8PKmDb3IfDUSjVd8ce O7v1cmSeI4o9EhHterB3TiUcEtu3cTsu2Byg2IJO2ymh4RY5slViJe5+/FHHBbcu R5QH4m/9RwHpfiHRZJ3uK5LBAgsKJgZx8GekVME+UxvJyYkngd/ioMkcQOQMZs8= =A+Wn -----END PGP SIGNATURE-----