From owner-freebsd-hackers  Fri Aug 16 17:24:42 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id RAA03472
          for hackers-outgoing; Fri, 16 Aug 1996 17:24:42 -0700 (PDT)
Received: from mail0.iij.ad.jp (root@mail0.iij.ad.jp [192.244.176.61])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id RAA03465;
          Fri, 16 Aug 1996 17:24:38 -0700 (PDT)
Received: from uucp1.iij.ad.jp (uucp1.iij.ad.jp [192.244.176.73]) by mail0.iij.ad.jp (8.6.12+2.4W/3.3W9-MAIL) with ESMTP id JAA01268; Sat, 17 Aug 1996 09:24:31 +0900
Received: (from uucp@localhost) by uucp1.iij.ad.jp (8.6.12+2.4W/3.3W9-UUCP) with UUCP id JAA08862; Sat, 17 Aug 1996 09:24:31 +0900
Received: from xxx.fct.kgc.co.jp by yyy.kgc.co.jp (8.7.5/3.4W4:96080715) id IAA17868; Sat, 17 Aug 1996 08:54:00 +0900 (JST)
Received: from localhost by xxx.fct.kgc.co.jp (8.6.12/3.3W8:95062916) id IAA11402; Sat, 17 Aug 1996 08:53:59 +0900
Message-Id: <199608162353.IAA11402@xxx.fct.kgc.co.jp>
To: pst@jnx.com
Cc: wollman@freebsd.org, freebsd-hackers@freebsd.org, olah@freebsd.org,
        candy@fct.kgc.co.jp
Subject: Re: bin/649 - fix questions (tcpdump / print-atalk.c)
In-Reply-To: Your message of "Fri, 16 Aug 1996 15:43:06 -0700"
References: <199608162243.PAA11091@base.jnx.com>
X-Mailer: Mew version 1.06 on Emacs 19.28.2, Mule 2.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Date: Sat, 17 Aug 1996 08:53:58 +0900
From: Toshihiro Kanda <candy@fct.kgc.co.jp>
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

From: Paul Traina <pst@jnx.com>
Date: Fri, 16 Aug 1996 15:43:06 -0700

> Back in September, you made a change to tcpdump's print-atalk.c code to
> fix PR # 649.  One of the changes was to print appletalk addresses in hex.
> This is not, to the best of my knowledge, correct.  Every network monitor or
> router that I've seen (cisco, gatorbox, et al) use decimal for the network
> number and node address.
> 
> I'd like to back this change out as part of the upgrade to the current tcpdump
> so that we return to canonical address displays.
> 
> Objections?

  No problem.  There are always confusion printing network number in
decimal, i.e. 0xfffe is printed as 255.254 or 65534.  I just disliked
this.

  By the way, print-atalk.c is still buggy in handling aarp packet.
I'd like to send a patch to fix it.  I diff(1)'ed print-atalk.c of
2.1.5R and mine.  Please check and merge below.

  Thank you.

candy@fct.kgc.co.jp (Toshihiro Kanda)

------8<------------8<------------8<------------8<------------8<------
*** print-atalk.orig.c	Sat Aug 17 08:47:16 1996
--- print-atalk.c	Sat Jan 27 15:30:47 1996
***************
*** 167,175 ****
  
  	printf("aarp ");
  	ap = (const struct aarp *)bp;
! 	if (ap->htype == 1 && ap->ptype == ETHERTYPE_ATALK &&
  	    ap->halen == 6 && ap->palen == 4 )
! 		switch (ap->op) {
  
  		case 1:				/* request */
  			(void)printf("who-has %s tell %s",
--- 167,175 ----
  
  	printf("aarp ");
  	ap = (const struct aarp *)bp;
! 	if (ntohs(ap->htype) == 1 && ntohs(ap->ptype) == ETHERTYPE_ATALK &&
  	    ap->halen == 6 && ap->palen == 4 )
! 		switch (ntohs(ap->op)) {
  
  		case 1:				/* request */
  			(void)printf("who-has %s tell %s",
***************
*** 178,184 ****
  
  		case 2:				/* response */
  			(void)printf("reply %s is-at %s",
! 			    AT(pdaddr), etheraddr_string(ap->hdaddr));
  			return;
  
  		case 3:				/* probe (oy!) */
--- 178,184 ----
  
  		case 2:				/* response */
  			(void)printf("reply %s is-at %s",
! 			    AT(psaddr), etheraddr_string(ap->hsaddr));
  			return;
  
  		case 3:				/* probe (oy!) */
------8<------------8<------------8<------------8<------------8<------