Date: Wed, 23 Aug 2023 03:41:47 +0000 From: bugzilla-noreply@freebsd.org To: testing@FreeBSD.org Subject: [Bug 265871] lib.libc.locale.c16rtomb_test.c16rtomb_utf_8_test failed after iconv changes on 2022-08-11 Message-ID: <bug-265871-32464-pOBXcGtFzN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-265871-32464@https.bugs.freebsd.org/bugzilla/> References: <bug-265871-32464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265871 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De2030ca246a777c50a7aacb3a35f88add= ded21cf commit e2030ca246a777c50a7aacb3a35f88addded21cf Author: Kyle Evans <kevans@FreeBSD.org> AuthorDate: 2023-08-23 03:40:45 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2023-08-23 03:40:45 +0000 libc: fix c*rtomb/mbrtoc* In 693f88c9da8d ("iconv_std: complete the //IGNORE support"), we more completely implemented //IGNORE, which changed the semantics of ci_discard_ilseq. DISCARD_ILSEQ semantics are supposed to match //IGNORE, so we really can't do much about that particular incompatibility. This broke c*rtomb and mbrtoc* handling of invalid sequences, but it turns out they don't want DISCARD_ILSEQ semantics at all; they really want the subset that we call _CITRUS_ICONV_F_HIDE_INVALID. This restores the exact flow in iconv_std to precisely how it happened prior to 693f88c9da8d. PR: 265871 Fixes: 693f88c9da8d ("iconv_std: complete the //IGNORE support") Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D41513 lib/libc/locale/cXXrtomb_iconv.h | 4 ++-- lib/libc/locale/mbrtocXX_iconv.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265871-32464-pOBXcGtFzN>