From owner-cvs-src@FreeBSD.ORG  Sat Oct 25 16:37:49 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DB37416A4B3; Sat, 25 Oct 2003 16:37:49 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 48D1643F93; Sat, 25 Oct 2003 16:37:49 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 412332ED44F; Sat, 25 Oct 2003 16:37:49 -0700 (PDT)
Date: Sat, 25 Oct 2003 16:37:49 -0700
From: Alfred Perlstein <bright@mu.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20031025233749.GW99943@elvis.mu.org>
References: <200310251614.h9PGE925019013@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200310251614.h9PGE925019013@repoman.freebsd.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_sig.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Oct 2003 23:37:50 -0000

This is bad, it's time to add a flag to the vnode to do this
properly instead of relying upon the underlying FS to implement
the locking.

* Robert Watson <rwatson@FreeBSD.org> [031025 09:14] wrote:
> rwatson     2003/10/25 09:14:09 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_sig.c 
>   Log:
>   When generate a core dump, use advisory locking in an advisory way:
>   if we do acquire an advisory lock, great!  We'll release it later.
>   However, if we fail to acquire a lock, we perform the coredump
>   anyway.  This problem became particularly visible with NFS after
>   the introduction of rpc.lockd: if the lock manager isn't running,
>   then locking calls will fail, aborting the core dump (resulting in
>   a zero-byte dump file).
>   
>   Reported by:    Yogeshwar Shenoy <ynshenoy@alumni.cs.ucsb.edu>
>   
>   Revision  Changes    Path
>   1.260     +6 -6      src/sys/kern/kern_sig.c

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684