From owner-svn-src-head@FreeBSD.ORG Fri Jun 1 06:24:13 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DAEFE1065670 for ; Fri, 1 Jun 2012 06:24:13 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 925D48FC21 for ; Fri, 1 Jun 2012 06:24:13 +0000 (UTC) Received: by obcni5 with SMTP id ni5so3110468obc.13 for ; Thu, 31 May 2012 23:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=hdD3gQLdSIWzwW6eOLWL7dnZYYyrm5058wju2mH7+Tc=; b=jMK/4XjIVqgiin6a1wk4X85du2BZh5kf4sK+3dBEPbkZVHAOop2H1+SJlMdikHcTmq 9v1fViDcLxdHDhivpYIEB87lKONOXDQWSbW4m9WqNx+mw7I7m9Te6JHTSCC5LASOKpdJ 7QFYNe94GxZ8usWnD8/1CZljoX2UJYpVqIKWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=hdD3gQLdSIWzwW6eOLWL7dnZYYyrm5058wju2mH7+Tc=; b=FNvIQXSh3Gs6EomO1G3+O00Ve1U04CXxw+B9seVQtwOACyS7rRYPCG7JpzavEak3gx QNGyC4U7S/dqkHAg6iP0wZZ7csmBJxAtnB3u+WjzR3TLLPQ0du22k7rZu/ljLrILcetR 3TYiGbqxYejyI8cq/P9w/mLHCMPaNCZz1kVqHlFYGGyHEvOOQj+EvCMkU4bYb8bMzPH/ AD0tGUiDJliBOTUZfy4ol8LYMNTKYIiQwj6bCnppP1JfwRvXKFGQlwizQfjRCxzQ+1BZ fqf4iENiTYI9lz0OVFk+UA5UV64gGPf7t0pAK+wLSfHfLnmrLNF3O5ZYngJN7kctlVw6 sdzA== Received: by 10.182.131.2 with SMTP id oi2mr1289887obb.43.1338531852980; Thu, 31 May 2012 23:24:12 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.182.204.69 with HTTP; Thu, 31 May 2012 23:23:42 -0700 (PDT) In-Reply-To: <20120601150242.V1226@besplex.bde.org> References: <201206010423.q514NKtf083043@svn.freebsd.org> <20120601150242.V1226@besplex.bde.org> From: Eitan Adler Date: Thu, 31 May 2012 23:23:42 -0700 X-Google-Sender-Auth: jo31WrorbtctJZdUPPm_uftyzwM Message-ID: To: Bruce Evans Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQljP3Uz0qB3USUgbUSxrMZrSXTkCLexAFK6Idgn5vWrAWGFGWp71FeO2XC4IVIv8EY2i76C Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236377 - head/sys/dev/vxge/vxgehal X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2012 06:24:13 -0000 On 31 May 2012 22:13, Bruce Evans wrote: > This seems to change a style by (excessive parentheses for a normal > equality test) into logic bug (assignment of dtrh instead of compariing > with it). intentional - perhaps my commit message was poorly worded. The comment above says 283 /* 284 * restore a previously allocated dtrh at current offset and update 285 * the available reserve length accordingly. If dtrh is null just 286 * update the reserve length, only 287 */ and gnn confirmed that the patch as committed is correct. -- Eitan Adler Source & Ports committer X11, Bugbusting teams