From owner-cvs-all@FreeBSD.ORG Wed Sep 22 15:30:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E315416A4D3; Wed, 22 Sep 2004 15:30:49 +0000 (GMT) Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net [69.140.212.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7783E43D46; Wed, 22 Sep 2004 15:30:49 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i8MFU8Bb093246; Wed, 22 Sep 2004 11:30:08 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i8MFU8V1093245; Wed, 22 Sep 2004 11:30:08 -0400 (EDT) (envelope-from green) Date: Wed, 22 Sep 2004 11:30:07 -0400 From: Brian Fundakowski Feldman To: Brooks Davis Message-ID: <20040922153007.GA91347@green.homeunix.org> References: <200409220859.i8M8xgwb022928@repoman.freebsd.org> <20040922130052.GA3407@green.homeunix.org> <20040922150105.GA17806@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040922150105.GA17806@odin.ac.hmc.edu> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2004 15:30:50 -0000 On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote: > On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wrote: > > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote: > > > brooks 2004-09-22 08:59:42 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/net if.c > > > Log: > > > Fix a LOR where ifconf() used copyout while holding a mutex. This LOR > > > was seen when configuring addresses on interfaces using ifconfig. This > > > patch has been verified to work with over eight thousand addresses > > > assigned to an interface. > > > > > > LOR id: 031 > > > > You really need to be running with INVARIANTS if you plan on committing > > kernel code, or people are likely to get angry when their systems crash > > for stupid reasons. > > Sorry about that. Pass the pointy had please. :-( No hard feelings, since I'm used to having a new issue or two every kernel upgrade, but this really should be a lesson to anyone listening that kernel development without INVARIANTS (and sometimes WITNESS) is a big no-no. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\