Date: Sat, 24 Dec 2011 20:04:41 +0200 From: Maxim Ignatenko <gelraen.ua@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr Message-ID: <CABWTX-Yy5sNsWdj%2B0CsOnf9uujW2GCwNxEFod5rz-sXGSo1Kig@mail.gmail.com> In-Reply-To: <D31DAF22-8941-4EAC-B05E-A860450F198E@bsdimp.com> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> <CADLo83-SK%2Bo0b9GysjhH0N=TxsZXLRAuKL-n%2Btt6%2BCcr1gAJWQ@mail.gmail.com> <74F7E2CE-89DC-4F64-9A50-71B9FD458025@bsdimp.com> <CABWTX-Z71U2OVFt8mH2n7BVcKX9eYGnk9YWY7b53i-RQeMJKtA@mail.gmail.com> <D31DAF22-8941-4EAC-B05E-A860450F198E@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 December 2011 19:51, Warner Losh <imp@bsdimp.com> wrote:
>
> On Dec 24, 2011, at 10:29 AM, Maxim Ignatenko wrote:
>
>>> =C2=A0If the 5% of cases are when someone has done something complicate=
d to the rc.conf file, then I don't care: they won't use this interface and=
we can detect this case and do nothing.
>>
>> Now I don't see how to distinguish cases when ${rcvar} set to default
>> value in rc-script and when it's set in other file in some not obvious
>> way.
>
> What does that matter?
>
In second case it should say something like "Unable to find where
${rcvar} was set". Now it adds ${rcvar}=3DYES to last included file in
both cases. This still should correctly enable or disable some service
unless /etc/rc.subr was modified to include some another file later,
but, as I understood, this is what was meant by "corner case
handling".
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABWTX-Yy5sNsWdj%2B0CsOnf9uujW2GCwNxEFod5rz-sXGSo1Kig>