From owner-svn-src-head@FreeBSD.ORG Thu May 21 13:36:40 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE54E106567E; Thu, 21 May 2009 13:36:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 3A3A48FC2C; Thu, 21 May 2009 13:36:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1M78Rp-00006I-5G; Thu, 21 May 2009 16:36:37 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n4LDaY3R009208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 May 2009 16:36:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n4LDaY8K019990; Thu, 21 May 2009 16:36:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n4LDaYsk019989; Thu, 21 May 2009 16:36:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 21 May 2009 16:36:34 +0300 From: Kostik Belousov To: Attilio Rao Message-ID: <20090521133634.GK1927@deviant.kiev.zoral.com.ua> References: <200905211322.n4LDM73t067924@svn.freebsd.org> <20090521132641.GJ1927@deviant.kiev.zoral.com.ua> <3bbf2fe10905210629p46c7a204v6863aaba77354462@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x7gJcYyRf5ZnuMVj" Content-Disposition: inline In-Reply-To: <3bbf2fe10905210629p46c7a204v6863aaba77354462@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.1 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1M78Rp-00006I-5G 173f0cec82480832f12c3ef551eab3e0 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r192535 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2009 13:36:51 -0000 --x7gJcYyRf5ZnuMVj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 21, 2009 at 03:29:57PM +0200, Attilio Rao wrote: > 2009/5/21 Kostik Belousov : > > On Thu, May 21, 2009 at 01:22:07PM +0000, Attilio Rao wrote: > >> Author: attilio > >> Date: Thu May 21 13:22:07 2009 > >> New Revision: 192535 > >> URL: http://svn.freebsd.org/changeset/base/192535 > >> > >> Log: > >> Move the M_WAITOK flag in notify() into an M_NOWAIT one in order to = match > >> the behaviour alredy present with the further malloc() call in > >> devctl_notify(). > >> This fixes a bug in the CAM layer where the camisr handler finished = to > >> call camperiphfree() (and subsequently destroy_dev() resulting in a = new > >> dev notify) while the xpt lock is held. > > This is wrong. You cannot call destroy_dev() while holding any mutex. > > Taking this into account, it makes no sense to use M_NOWAIT in notify(). >=20 > As long as devctl_notify() also calls M_NOWAIT and if not available > skips "silently" it just does the same thing, I think this approach is > more consistent. M_NOWAIT currently uses system reserve for page allocation, so less it is used, the better. >=20 > It remains, though, the fact to fix CAM when calling destroy_dev(). > Maybe we should add a witness_warn() there? Destroy_dev already has the warning, see line 853. --x7gJcYyRf5ZnuMVj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkoVWOEACgkQC3+MBN1Mb4ixLgCgtDfBmNjAHFRfm4SvdUOg+nxk RcoAnjj4D/ADNLHhUTQXY95hysF1Y9bQ =4jIH -----END PGP SIGNATURE----- --x7gJcYyRf5ZnuMVj--