From owner-svn-src-all@freebsd.org Wed Apr 25 02:11:10 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A21E5FBA7C5 for ; Wed, 25 Apr 2018 02:11:10 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic314-29.consmr.mail.bf2.yahoo.com (sonic314-29.consmr.mail.bf2.yahoo.com [74.6.132.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46B4D7D4B4 for ; Wed, 25 Apr 2018 02:11:10 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1524622269; bh=ltfgjc3bNoeFjhdd7FfeawZpEUUnqunN+EU9tZmKxd8=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=QMohCae9iabkBv8P+dj/9M6lrVc6lNjSy8RLWJjCxWAbjt1A7HQnGd2ws4iTQzxtZigUjIj7EteqSxDpHenwAjvovvqq0mFs2e8DONY2dYjJoXv9jZY7uXVCJ1xwl/SQOVRietgP1UYBrZ+koZFr/MvsDyLOP6rsvOp1p11r2yhbhkpd4+ZGNNz3JFeehtGOepSfPVNbGWkksyLs99eXHcveEYWUNr+cZKa2pt4qr/xD4T0Z7LhjyPkKRvFY3/6Bq/eMax9Zhmra/epueLmxE++h8to8qJYrEBY8Btx0X+g3Zeyb+h6o4mfOFXRf5iKnRQeWFLh4XygDK/6jEetl+g== X-YMail-OSG: 8EK.63sVM1m9vMJ.UHsVWJyIfngrG8f8iXVBf7MfimMc4XHhdCqR7NGYaW0xRra ev5p3bJP2H5uj.hU8f6NTDjgUfHy_f93CDnSSxgsBbbqh.iZG5rDj2e6bDMkmOE.pICMSKkFFqLx cKflIuDDpcpcEOosvTLltckTjaFW8mf0P4pSKDZ3eroFRGGFwvBDY_e1mnufNU8MCcy6ndVRZplY hT0BUhVw9f8qCtGYTexwUJgUeYJCcl8d8cV75bzFmQPCOhmlcemf0Z1wccou9PJzP3Yem9QGeMqk 5VXw5u6dBjb7fy4aX1iaxp2f.kBMDuurNvU.HjLaWZOkoFZo05Zk3QtpShKiq9GhAsCBtucYr812 GZQbf6qFhGO10CHR.cRm6BdFJ5DdTQSUAAX71CfLWnPsZxY7qbcK5E9R2465TVfGlOmcy_crH.Yd WgpuP_5UaWfDLZSHIfn32fkVfqjTbRxzacAjrXqhrBs24UaZN.GEkjNeAnpdggGq8Q7pvLUWAVtl uy2MtSVJbPP7Rc8BE.isf6_veMR7jnZmQjFTiF.apLjlmxdxr_ljUsu9qT.jf5zuDTiKpZR11eL8 1wp62A_wPw1.ShFRz0jZW9.24oM4_zjamX2_C Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Wed, 25 Apr 2018 02:11:09 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.6]) ([181.52.72.201]) by smtp431.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5f62a8a795b61142a4fe2afd4fa50620; Wed, 25 Apr 2018 01:50:56 +0000 (UTC) Subject: Re: svn commit: r332980 - in stable/11/usr.sbin/makefs: . cd9660 ffs To: Benno Rice , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <201804250135.w3P1Z6Xt084500@repo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: Date: Tue, 24 Apr 2018 20:50:55 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <201804250135.w3P1Z6Xt084500@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 02:11:10 -0000 On 24/04/2018 20:35, Benno Rice wrote: > Author: benno > Date: Wed Apr 25 01:35:06 2018 > New Revision: 332980 > URL: https://svnweb.freebsd.org/changeset/base/332980 > > Log: > MFC r307927 > > Be more precise when including headers so that we're less likely to > depend on namespace pollution and as such become more portable. This > means including headers like or , but also > making sure we include system/host headers before local headers. > > While here: define ENOATTR as ENOMSG in mtree.c. There is no ENOATTR > on Linux. > Nope. ... > Modified: stable/11/usr.sbin/makefs/mtree.c > ============================================================================== > --- stable/11/usr.sbin/makefs/mtree.c Wed Apr 25 01:30:29 2018 (r332979) > +++ stable/11/usr.sbin/makefs/mtree.c Wed Apr 25 01:35:06 2018 (r332980) > @@ -46,10 +46,15 @@ __FBSDID("$FreeBSD$"); > #include > #include > #include > +#include > #include > #include > > #include "makefs.h" > + > +#ifndef ENOATTR > +#define ENOATTR ENOMSG > +#endif > > #define IS_DOT(nm) ((nm)[0] == '.' && (nm)[1] == '\0') > #define IS_DOTDOT(nm) ((nm)[0] == '.' && (nm)[1] == '.' && (nm)[2] == '\0') This should be ENODATA, see r326282 for reference. Cheers, Pedro.