From owner-freebsd-hackers@freebsd.org Fri May 20 10:53:37 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80144B43BAD for ; Fri, 20 May 2016 10:53:37 +0000 (UTC) (envelope-from ml@my.gd) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F9B31D5E for ; Fri, 20 May 2016 10:53:37 +0000 (UTC) (envelope-from ml@my.gd) Received: by mail-io0-x229.google.com with SMTP id f8so8794186ioe.3 for ; Fri, 20 May 2016 03:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=my-gd.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=mTw0zsSIpm4p8RTwPQ3bJaLeOLawrK82zw2pxi39B1A=; b=lONeF/9GKURvzpB6jsXXllFhWyyEIvS4UlvYAdGn8DmHNqAvPqyY2clLOa2abXhK1o HSDhTLIxwCtzAIzIkmun+XAyeqR9gks0k28IqqqHOPApPnspwScTAvB2aR+McvIBUtKI 2OZtEssQxk63gCWj1KbE2om8WSm7jabh6PvvpmXE8oYS+6y3GAltpwpCcudBGrxbua7S zKrdDAof2sXEB5bIeSlZ0K0xEh996DNK5elL2YXRgsQ9V1lDRvatlrpsOR7HXa2I0dPT rxXppk28MTWWm2omhtC9kRzSqSaFiKMyK9ghWavwbBTbNRMSkHRqBpru5lbrGrY9/4Y4 WdDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=mTw0zsSIpm4p8RTwPQ3bJaLeOLawrK82zw2pxi39B1A=; b=hinZPfm/BcGq26CI741SnY85xVV9N3G9CxG/QbrEW0TVEUmXzd7AyPNye6DyJQSBIb M9I5unyiKAnT6dMysZ5N3ye0Xnwpm/Ojy+1GT/ZCPgz/1Ue63nI5F+M7odWJ1ff5sOvx cEe+RDp+rOy+/TkwmT1x56WPdzXOMj/Y8OLZbwwOzbb1Z50qerxl55uTrxZoybFbDSAy P5sbM17uS2ODfXpKqdtpD3WWNW1rWVNRXaAVA8kzocd0VQP2MSUkVMuJL6VqBTn4R+D0 Ab0R3y83Vzb+tNyitWFCa6uL1Jsa1Zre81m46/7rN5K0IBGV0xTqIP0j7s7f0wrdH1K4 ui8g== X-Gm-Message-State: AOPr4FXdX9WK+pa+fA9PCeWhwrGPlCxheB50cgmtKvQAXyppxcijVDhFPCNtgGFSF5O9r+u1OaBPC1FzETad7g== MIME-Version: 1.0 X-Received: by 10.107.56.131 with SMTP id f125mr2294612ioa.188.1463741616576; Fri, 20 May 2016 03:53:36 -0700 (PDT) Received: by 10.79.124.93 with HTTP; Fri, 20 May 2016 03:53:36 -0700 (PDT) In-Reply-To: <20160519212934.GF19887@gmail.com> References: <20160519041118.GE19887@gmail.com> <573D3DA7.20600@freebsd.org> <20160519212934.GF19887@gmail.com> Date: Fri, 20 May 2016 12:53:36 +0200 Message-ID: Subject: Re: What changes are welcome? From: Damien Fleuriot To: freebsd-hackers@freebsd.org Cc: Allan Jude , Randy Westlund Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 10:53:37 -0000 On 19 May 2016 at 23:29, Randy Westlund wrote: > On Thu, May 19, 2016 at 12:14:31AM -0400, Allan Jude wrote: > > Generally, you likely want to avoid changing anything from contrib/ or > > vendor/, as that is code from other projects that is imported, and local > > changes complicate that. Of course, top is not really maintained > > 'upstream' anymore, so maybe it isn't a bad place to start. > > > > Phabricator is likely the best place for patches, it is much easier to > > review. > > Indeed, looks like it's been 16 years. I silenced 131 warnings. > > https://reviews.freebsd.org/D6468 > Sorry for hijacking ;) On the topic of contributing, there's a bug report I filed almost a year ago for net/relayd [1] The submitted change is very minor and mimics nginx's behaviour, adding a configuration sanity check before restarting or reloading net/relayd. Is there a better place for me to submit this, or would someone have the spare time to take a look ? Cheers :) [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200914