From owner-cvs-all Wed Jan 24 23:35:21 2001 Delivered-To: cvs-all@freebsd.org Received: from mobile.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147]) by hub.freebsd.org (Postfix) with ESMTP id 6A8E537B402; Wed, 24 Jan 2001 23:34:50 -0800 (PST) Received: from netplex.com.au (localhost [127.0.0.1]) by mobile.wemm.org (8.11.1/8.11.1) with ESMTP id f0P7XH490063; Wed, 24 Jan 2001 23:33:18 -0800 (PST) (envelope-from peter@netplex.com.au) Message-Id: <200101250733.f0P7XH490063@mobile.wemm.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: John Hay Cc: imp@harmony.village.org (Warner Losh), jhay@FreeBSD.org (John Hay), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa if_ar.c if_arregs.h src/sys/pci if_ar_p.c In-Reply-To: <200101250700.f0P70ka99921@zibbi.icomtek.csir.co.za> Date: Wed, 24 Jan 2001 23:33:17 -0800 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Hay wrote: > > : Modified files: > > : sys/i386/isa if_ar.c if_arregs.h > > : sys/pci if_ar_p.c > > : Log: > > : Newbusify ar(4). > > > > The convention that we've used in the past is to move the newbusified > > drivers to sys/dev/ar and call the isa attachment if_ar_isa.c and the > > pci attachment if_ar_pci.c. > > Ok, what should I do with i386/isa/ic/hd64570.h? Do we have a common > place for things like that? It isn't really related to ISA and in > this case it will be used by more than one driver. At least ar(4) and > sr(4). This is bikeshed material, but NetBSD put things like that in dev/ic/*. There are others too, eg: if_the wavelan_ieee.h that I tripped over and broke when moving wi to dev/wi (I broke if_wl.c). Some ideas: dev/ic dev/common dev/include .. actually, I think I like the second most. it means we can put shared header files in sys/dev/common and have that automatically installed with the other includes, and any common C code that is shared between drivers (eg: some 3com stuff) as well. If there was a common components there could be, for example: dev/common/hd64570.h dev/common/hd64570.c Can anybody not live with this? ie: dev/common ? Userland could #include . Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message