From owner-svn-src-head@freebsd.org Sun May 31 09:43:30 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E597F3306DE; Sun, 31 May 2020 09:43:30 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49ZYJx27G0z3Wms; Sun, 31 May 2020 09:43:28 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590918206; bh=SLVeO+gTejBT/pLrUCjC2NXN2wwCpVzZzXBKW48hu8A=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=JB50eDeOCEYFX/kO8rg5YfWAq2PyB0m0g7D7P2yPcndPdoLfmzdOr2q9ZIF8DR8Es ucC0vcRjCxbDa2bXAE7NNPgBwKte5y3mSniWSXRK7mUfFPn5+v89XaNUzYWldZvQzk dwQb/Lk30p2TEiNZUADVWRhZ2EMwT7ciJos28a3g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([77.183.27.134]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mjj87-1jGP8H1RHf-00lHQK; Sun, 31 May 2020 11:43:26 +0200 Date: Sun, 31 May 2020 11:43:18 +0200 From: "Hartmann, O." To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361633 - in head/sys: net netipsec Message-ID: <20200531114318.2b415934@hermann.fritz.box> In-Reply-To: <202005291922.04TJMemQ098017@repo.freebsd.org> References: <202005291922.04TJMemQ098017@repo.freebsd.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/K9D9Cgo_rXCeD=+Maiy_5WL"; protocol="application/pgp-signature" X-Provags-ID: V03:K1:CxRr1AFzSFlH6AxXMwlIpKXZqCgCL0YSnpz/EzWfxoYbkHsavSL ppp9QQlmauCfB/4FLku0luhsMmgEgZNi36EsM3PcRVkA6Jpjgd0XCuRmsMqzeyl5jNttPOm Y2U/RInQEs6sEf+XFPo3VH4y3zTa+XHsdiE6AvyZc+GeMkWLEPCl56J2I7qEcrq0tB5GhCK te4oIGOpgLwBECeqfIUJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:IhAFclkvXdw=:uIrLLsZntw4B/AXLpC0RRR qS52+nXv1Qos19NRt0BRpkmKVl8Q00uNaXmeX9j//ZWfY52/IwU0k6Q9KUtMuS8Uu4eoEbXT9 PQ2hVWRCJ6BIoGCzfjeyPCNgpQVGdn3N4DtAo5O+nfq+stR6Fo32lqQ1458YOOM2QUWJ7zdEY nKsLPnLi7b7LhHJ9/i0v/FQIzPCQ/ZkwchKbH8tIxKjNW4V1RrP1ortEOiYtWieDu7zTLDOd7 h4NI23quu0n8nqCmDrN1Otd8AyeAJvt2LEPIQeTopMXgIFzWKw5ODAtKOTDJB82RVOfqCmOdx tuWmbAjnUxgOstUWiTjwXVgLeVRG5lTcc1u7zxdFaQzXkqoRTrol2DfEC23RsD7V1CgsfkDpI GMXjdCmUzoJUP9B3+qs4lmmnumj39p9Cwtx/yl86BZIG00y1JE9pTMr6RalaoxAOz9a80ooUU Z3SAy+iT/Jxto4ztsX7cRSmmN/WpVqwlmsYhTWnCFI/nPxDAWjUKW+71uXV1ln9ppSBO7ELCt fd/+k2UsMPnujnmLxryeKPROXSpQf+Ntx72VhLm0AR6vg9Pwl/jDofGMWtGqkeFnHJGwQtjae UbmpIYZtfd3/Wrd8pGqiADG93FVKfCTevpz0XKNRhZAVHAklQSYadJVb1ig60CoW4PDcIzNwB U+2OHDog9f+Pd5HqZ2EurM2KeEiMYsxdWzdQAURqNPwVWNO5WK5HRn3CqAs3dl2vog6V1R6Qy CESLzR0FtuvuafdG96bXPgW4YRmUgkK4Rq9+k6oBPC8iGKGkIJWpFtOXEzx2/5MhWtStjML/D L1jWI8uc4zYTDY21PzKJSVjy9lRzICYR50aAFHz2Vjeh2INo/TxF5v1Hk3r+ZbcOl+DkJKIHM Sv1bQPaeUPA8gvMnTZ6ar3sAWBuwUdBuwjf5BR9lvq8W8Mk2lk0nN1XoSrQBmgLYlFPkHa3KF AlTXOXE4yMf/mpgGTxfUMQ9XuDHR0SPxNyYl6FlY+GLuh2TTEgzrEbcAqA34oWtaKhmP9FMxN BYavenPCOqiwlHZpRTfRuzsj6pwfROH06257YxEZMrDR+DVuE/ZiOOP5W6Sf5gY4bQ2qfzsgv VupfaUG5dLH0V1aldhsb80zTQGxdxcLKbQVIm0IbP4ou2jQne/mQ/itdxknrI4kpFIAfUKLoU hZCRbtQ5HN9bYbML1u8LCJTZVoAv0or6+xjoAAa4Eysf/+FWtsy1LH8OjZniJuhhOPrylE8UY HzOXuHJRj2k56yQGM X-Rspamd-Queue-Id: 49ZYJx27G0z3Wms X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=JB50eDeO; dmarc=none; spf=none (mx1.freebsd.org: domain of ohartmann@walstatt.org has no SPF policy when checking 212.227.17.22) smtp.mailfrom=ohartmann@walstatt.org X-Spamd-Result: default: False [-2.45 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; RWL_MAILSPIKE_POSSIBLE(0.00)[212.227.17.22:from]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[walstatt.org]; NEURAL_HAM_LONG(-0.46)[-0.457]; HAS_ORG_HEADER(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[77.183.27.134:received]; NEURAL_HAM_MEDIUM(-0.82)[-0.817]; DKIM_TRACE(0.00)[gmx.net:+]; NEURAL_HAM_SHORT(-0.68)[-0.678]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.17.22:from] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2020 09:43:31 -0000 --Sig_/K9D9Cgo_rXCeD=+Maiy_5WL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 29 May 2020 19:22:40 +0000 (UTC) John Baldwin wrote: > Author: jhb > Date: Fri May 29 19:22:40 2020 > New Revision: 361633 > URL: https://svnweb.freebsd.org/changeset/base/361633 >=20 > Log: > Consistently include opt_ipsec.h for consumers of > .=20 > This fixes ipsec.ko to include all of IPSEC_DEBUG. > =20 > Reviewed by: imp > MFC after: 2 weeks > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D25046 >=20 > Modified: > head/sys/net/if_enc.c > head/sys/net/if_ipsec.c > head/sys/netipsec/ipsec.h > head/sys/netipsec/ipsec_mbuf.c > head/sys/netipsec/xform_ah.c > head/sys/netipsec/xform_esp.c > head/sys/netipsec/xform_ipcomp.c >=20 > Modified: head/sys/net/if_enc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/if_enc.c Fri May 29 19:21:35 2020 > (r361632) +++ head/sys/net/if_enc.c Fri May 29 19:22:40 > 2020 (r361633) @@ -32,6 +32,7 @@ > =20 > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_ipsec.h" > =20 > #include > #include >=20 > Modified: head/sys/net/if_ipsec.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/net/if_ipsec.c Fri May 29 19:21:35 2020 > (r361632) +++ head/sys/net/if_ipsec.c Fri May 29 19:22:40 > 2020 (r361633) @@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$"); > =20 > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_ipsec.h" > =20 > #include > #include >=20 > Modified: head/sys/netipsec/ipsec.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netipsec/ipsec.h Fri May 29 19:21:35 2020 > (r361632) +++ head/sys/netipsec/ipsec.h Fri May 29 19:22:40 > 2020 (r361633) @@ -39,11 +39,6 @@ > #ifndef _NETIPSEC_IPSEC_H_ > #define _NETIPSEC_IPSEC_H_ > =20 > -#if defined(_KERNEL) && !defined(_LKM) && !defined(KLD_MODULE) > -#include "opt_inet.h" > -#include "opt_ipsec.h" > -#endif > - > #include > #include > =20 >=20 > Modified: head/sys/netipsec/ipsec_mbuf.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netipsec/ipsec_mbuf.c Fri May 29 19:21:35 > 2020 (r361632) +++ head/sys/netipsec/ipsec_mbuf.c Fri > May 29 19:22:40 2020 (r361633) @@ -32,6 +32,8 @@ > * IPsec-specific mbuf routines. > */ > =20 > +#include "opt_ipsec.h" > + > #include > #include > #include >=20 > Modified: head/sys/netipsec/xform_ah.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netipsec/xform_ah.c Fri May 29 19:21:35 > 2020 (r361632) +++ head/sys/netipsec/xform_ah.c Fri May > 29 19:22:40 2020 (r361633) @@ -38,6 +38,7 @@ > */ > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_ipsec.h" > =20 > #include > #include >=20 > Modified: head/sys/netipsec/xform_esp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netipsec/xform_esp.c Fri May 29 19:21:35 > 2020 (r361632) +++ head/sys/netipsec/xform_esp.c Fri > May 29 19:22:40 2020 (r361633) @@ -37,6 +37,7 @@ > */ > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_ipsec.h" > =20 > #include > #include >=20 > Modified: head/sys/netipsec/xform_ipcomp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/netipsec/xform_ipcomp.c Fri May 29 19:21:35 > 2020 (r361632) +++ head/sys/netipsec/xform_ipcomp.c Fri > May 29 19:22:40 2020 (r361633) @@ -33,6 +33,7 @@ > /* IP payload compression protocol (IPComp), see RFC 2393 */ > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_ipsec.h" > =20 > #include > #include > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org" In my case, kernel build (make buildkernel) fails with the comnpiler error shown below while compiling ipsec kernel module. Kernel has IPSEC support enabled. Kind regards, oh [...] --- all_subdir_ipsec --- --- ipsec_mod.o --- /usr/src/sys/netipsec/ipsec_mod.c:114:3: error: implicit declaration of function 'ipsec_support_enable' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); ^ /usr/src/sys/netipsec/ipsec_mod.c:125:3: error: implicit declaration of function 'ipsec_support_disable' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ipsec_support_disable(ipv4_ipsec_support); ^ --- all_subdir_ipwfw --- Building /usr/obj/usr/src/amd64.amd64/sys/WALHALL/modules/usr/src/sys/modules/ipwfw/= ipw_bss/ipw_bss.ko --- all_subdir_ipsec --- /usr/src/sys/netipsec/ipsec_mod.c:125:3: note: did you mean 'ipsec_support_enable'? /usr/src/sys/netipsec/ipsec_mod.c:114:3: note: 'ipsec_support_enable' declared here ipsec_support_enable(ipv4_ipsec_support, &ipv4_methods); ^ 2 errors generated. *** [ipsec_mod.o] Error code 1 make[4]: stopped in /usr/src/sys/modules/ipsec --Sig_/K9D9Cgo_rXCeD=+Maiy_5WL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCXtN8NgAKCRA4N1ZZPba5 R+slAP9mYisSDV9d4PSHyPpmlYx/nhzyAcRXcFYhHsYkF1Iq4AEAjCGyYeezL8Wy gIA6nPAr2lcW2uhz2YaHQyufT+CnfQc= =NBKq -----END PGP SIGNATURE----- --Sig_/K9D9Cgo_rXCeD=+Maiy_5WL--