From owner-svn-ports-head@freebsd.org Tue Jun 25 01:59:38 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34E8C15B4655; Tue, 25 Jun 2019 01:59:38 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CE696B471; Tue, 25 Jun 2019 01:59:37 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x544.google.com with SMTP id n2so8065469pgp.11; Mon, 24 Jun 2019 18:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WDl8gNMM0Gsv9ySipxf1We3JbCIBValvi+YxTo/6QBM=; b=d9JtHezvOJNA7+5KCzrJZ3ynkljQHXWjnCla3/2EELTEO5UQUWjXCnQy1xJOxQsPM1 x6VETNhBWRX5bwpDUhdPrQ56AXIFyLfNP7Lh3ktBUdLG15/eo49xq6JlxiGTX/evquOY SOJHKeydaEfdhL9ZtnSXN/PMb9kJt4pjGfBgpCLGSVQwcVkPFWNh837Vdz6XnsA0SLeV ++o9EtT8qZbjYKDOxVIYBrYky2C+ZqHTFEYe4SHDkVme6OHLl7OhqPWS9fiJQVkneF3D TRFZp5wxW+zN5xjwrnT+GJHpbZo+nsAqBR3O83fNuu/JC+MjMhPwL0efzyk4oh4Plcbw eKww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WDl8gNMM0Gsv9ySipxf1We3JbCIBValvi+YxTo/6QBM=; b=DgzBldeQjQif2XRoMz91R3uBWAVzNb/AViOfUWSsWTAOdKeTtoLDqCC1F+iRsXKlfC +iqO3Qiaysp8ssOhY2Q0LexDl4h7zRPXlbdoX92ddMgbGtTkPtPpnz3Xz/iyqxEmJiFS BV+YKFGlfQj+8po/Tg48lMk5Fu9LbfjYOsPFd4f4IX7FNJBgcO57/lgumZXXPArKQD7F 4H86qnFFHi2NuF2n64tB5hgifyKwQmpC48bPDmsNyosufVjHDOBAuYUYRaS87mLzYA8A CrS91+MZQNzozd0UhFKoJrpRR/f3LNzvg8+bZ4n2k2rjhbaaEDC/PLj2Meu3dLv15MUV 4g7g== X-Gm-Message-State: APjAAAWBJBCvCxQ/vBa/xORHovnVltHI9lTwzfNpxBKfZnz1LyO5dIrc b107DNlhjIHWbY7g0Z5KUVJR/o6m X-Google-Smtp-Source: APXvYqwqRL9M66dMDZs73EnRWs9l5EyhA0V1s9mTQ3y3pyCJpyJpF3Y4Elu/hj8WikyC7erAaBUz7w== X-Received: by 2002:a63:5961:: with SMTP id j33mr34780702pgm.89.1561427976349; Mon, 24 Jun 2019 18:59:36 -0700 (PDT) Received: from [192.168.1.103] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id f64sm10487554pfa.115.2019.06.24.18.59.34 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 18:59:35 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard To: Piotr Kubaj , "Tobias C. Berner" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> From: Kubilay Kocak Message-ID: <8eab69dc-52bb-a187-6a30-565ae58f4512@FreeBSD.org> Date: Tue, 25 Jun 2019 11:59:32 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9CE696B471 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 01:59:38 -0000 On 25/06/2019 6:27 am, Piotr Kubaj wrote: > OK, for me maintainer-feedback entry means that the patch is accepted. > > When I wasn't a committer, I used to set maintainer-feedback to indicate > that I accept the patch. When I send PR's nowadays, some maintainers > also do that. > > On 19-06-24 21:54:56, Tobias C. Berner wrote: >> I set maintainer feedback, because I, as the maintainer gave you the >> feedback, that "I think this is wrong" :) >> If I liked that patch, I would have set the patch-approved flag on it. >> >> >> All that said, thanks for "fixing" it, but I still would prefer a real >> fix, >> that we can upstream rather than that. >> >> >> mfg Tobias >> >> >> On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj wrote: >> >>> Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that >>> it's >>> accepted? >>> >>> On 19-06-24 21:34:09, Tobias C. Berner wrote: >>> >Moin moin >>> > >>> >Sorry, but I explicitely did not approve this :) so using implicit >>> on it, >>> >is a bit of a crappy move. >>> > >>> >mfg Tobias >>> > >>> >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj wrote: >>> > >>> >> Author: pkubaj >>> >> Date: Mon Jun 24 18:10:55 2019 >>> >> New Revision: 505045 >>> >> URL: https://svnweb.freebsd.org/changeset/ports/505045 >>> >> >>> >> Log: >>> >>   sysutils/plasma5-ksysguard: fix build with GCC-based architectures >>> >> >>> >>   Link with libinotify explicitly to fix linking on GCC >>> architectures. >>> >> >>> >>   PR:           238702 >>> >>   Approved by:  tcberner (maintainer, mentor) >>> >> >>> >> Modified: >>> >>   head/sysutils/plasma5-ksysguard/Makefile >>> >> >>> >> Modified: head/sysutils/plasma5-ksysguard/Makefile >>> >> >>> >> >>> ============================================================================== >>> >>> >> --- head/sysutils/plasma5-ksysguard/Makefile    Mon Jun 24 >>> 18:07:12 2019 >>> >>       (r505044) >>> >> +++ head/sysutils/plasma5-ksysguard/Makefile    Mon Jun 24 >>> 18:10:55 2019 >>> >>       (r505045) >>> >> @@ -23,5 +23,6 @@ OPTIONS_SUB=  yes >>> >> >>> >>  INOTIFY_DESC=          Filesystem alteration notifications using >>> inotify >>> >>  INOTIFY_LIB_DEPENDS=   libinotify.so:devel/libinotify >>> >> +INOTIFY_LDFLAGS=       -linotify >>> >> >>> >>  .include What could we (bugmeister) name the flag so that it was clear that a) The flag is about needing feedback b) The flag has nothing to do with / does not mean approval?