From owner-freebsd-current@FreeBSD.ORG  Wed Jun 18 16:50:03 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D4C9037B401
	for <current@FreeBSD.org>; Wed, 18 Jun 2003 16:50:03 -0700 (PDT)
Received: from Shenton.org (23.ebbed1.client.atlantech.net [209.190.235.35])
	by mx1.FreeBSD.org (Postfix) with SMTP id 82AB143F85
	for <current@FreeBSD.org>; Wed, 18 Jun 2003 16:50:02 -0700 (PDT)
	(envelope-from chris@Shenton.Org)
Received: (qmail 58823 invoked by uid 1000); 18 Jun 2003 23:49:09 -0000
To: Don Lewis <truckman@FreeBSD.org>
References: <200306180320.h5I3KjM7053484@gw.catspoiler.org>
From: Chris Shenton <chris@shenton.org>
Date: 18 Jun 2003 19:49:09 -0400
In-Reply-To: <200306180320.h5I3KjM7053484@gw.catspoiler.org>
Message-ID: <87u1an9cay.fsf@PECTOPAH.shenton.org>
Lines: 34
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
cc: current@FreeBSD.org
Subject: Re: 5.1-CURRENT hangs on disk i/o? sysctl_old_user() non-sleepable
	locks
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jun 2003 23:50:04 -0000

Don Lewis <truckman@FreeBSD.org> writes:

> Try the very untested patch below ...

> RCS file: /home/ncvs/src/sys/kern/uipc_syscalls.c,v
> retrieving revision 1.150
> Try the very untested patch below ...
> diff -u -r1.150 uipc_syscalls.c
> --- uipc_syscalls.c	12 Jun 2003 05:52:09 -0000	1.150
> +++ uipc_syscalls.c	18 Jun 2003 03:14:42 -0000
> @@ -1775,10 +1775,13 @@
>  	 */
>  	if ((error = fgetvp_read(td, uap->fd, &vp)) != 0)
>  		goto done;
> +	vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td);
>  	if (vp->v_type != VREG || VOP_GETVOBJECT(vp, &obj) != 0) {
>  		error = EINVAL;
> +		VOP_UNLOCK(vp, 0, td);
>  		goto done;
>  	}
> +	VOP_UNLOCK(vp, 0, td);

Tried it, rebuilt kernel, rebooted, no affect :-(

You were correct about apache using it.  Doing a simple

  fetch http://pectopah/

causes the error, dropping me into ddb if panic enabled. A "tr" shows
the same trace as I submitted yesterday :-(

Time to find that null modem cable.

Thanks.