From owner-freebsd-ports-bugs@freebsd.org Wed Jan 1 20:54:16 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 809131DFFB4 for ; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47p3Lc2vblz4MDj for ; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 61B3E1DFFB0; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 616B71DFFAF for ; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47p3Lc1nlTz4MDg for ; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 38F7B86AA for ; Wed, 1 Jan 2020 20:54:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 001KsG1t023997 for ; Wed, 1 Jan 2020 20:54:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 001KsGbP023996 for ports-bugs@FreeBSD.org; Wed, 1 Jan 2020 20:54:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 242940] games/devilutionX 1.0.0: version update and fixed some issues Date: Wed, 01 Jan 2020 20:54:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: swills@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2020 20:54:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242940 --- Comment #3 from Steve Wills --- Thanks, overall this looks good. A few minor comments on the patch: LOCALBASE is where other ports/packages installed things, PREFIX is where *this* port/package is going to install things. I think CMAKE_INSTALL_SHARE= DIR should reference PREFIX. CMAKE_BUILD_TYPE is already set based on WITH_DEBUG, perhaps you just need = to duplicate the logic from here: https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=3D488341&vi= ew=3Dmarkup#l65 since I guess they don't use the standard build type names. Setting __BSD_VISIBLE and such is usually not advisable, instead it may be = that you need to specify the compiler standard. Also, hopefully you would be abl= e to use standard cmake flags instead of patching the CMakeLists.txt for that. (Checking CMAKE_SYSTEM_NAME does make sense tho, please keep that and send = it upstream.) Probably better to just remove the OS name from devilutionx.desktop entirel= y, it's not really required, people know what OS they're on. (And Dragonfly wouldn't have to re-patch it.) --=20 You are receiving this mail because: You are the assignee for the bug.=