From owner-svn-src-head@FreeBSD.ORG Wed Jun 10 10:02:15 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3953106564A; Wed, 10 Jun 2009 10:02:14 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id AEF908FC19; Wed, 10 Jun 2009 10:02:14 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 32B936D418; Wed, 10 Jun 2009 12:02:13 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 0A138844DC; Wed, 10 Jun 2009 12:02:13 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Kip Macy References: <200906100121.n5A1LWVO089719@svn.freebsd.org> <3c1674c90906092324n58e16154s6800e61752282e42@mail.gmail.com> <3c1674c90906100008i4c632312j32f223b8aca14934@mail.gmail.com> Date: Wed, 10 Jun 2009 12:02:12 +0200 In-Reply-To: <3c1674c90906100008i4c632312j32f223b8aca14934@mail.gmail.com> (Kip Macy's message of "Wed, 10 Jun 2009 00:08:43 -0700") Message-ID: <86ljo0wgnv.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dmitry Morozovsky Subject: Re: svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 10:02:15 -0000 Kip Macy writes: > Dmitry Morozovsky writes: > > Hmm, I failed to see how boolean prevent the usage: > > > > if arch=3D=3Di386 || memsize < 4G > > =C2=A0 =C2=A0 =C2=A0 =C2=A0zfs_prefetch=3D0 > > else > > =C2=A0 =C2=A0 =C2=A0 =C2=A0zfs_prefetch=3D1 > > > > and admin can flip the switch to non-default position. > > > Right, what you're advocating is zfs_prefetch_non_default. Which is > simpler, but still rather weird. No, he's advocating zfs_prefetch_enable which is initialized to either 0 or 1 at boot time and can be administratively set to either 0 and 1 regardless of its initial value. I don't see the problem... DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no