From owner-cvs-src@FreeBSD.ORG Mon Jul 30 14:41:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8D9016A419; Mon, 30 Jul 2007 14:41:11 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4513C13C474; Mon, 30 Jul 2007 14:41:11 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l6UEeds3096342; Mon, 30 Jul 2007 08:40:39 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 30 Jul 2007 08:40:45 -0600 (MDT) Message-Id: <20070730.084045.-1889956848.imp@bsdimp.com> To: des@des.no From: "M. Warner Losh" In-Reply-To: <86k5sijlge.fsf@ds4.des.no> References: <86zm1ejrat.fsf@ds4.des.no> <20070730.025750.41720145.imp@bsdimp.com> <86k5sijlge.fsf@ds4.des.no> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 30 Jul 2007 08:40:39 -0600 (MDT) Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, bz@FreeBSD.org, mjacob@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2007 14:41:11 -0000 In message: <86k5sijlge.fsf@ds4.des.no> Dag-Erling_Sm=F8rgrav writes: : Warner Losh writes: : > Thank you for your opinion. However, make universe is not worthles= s. : > If doing one, and checking the output for errors, isn't sufficient = to : > get tinderbox to not whine, then tinderbox is broken. : = : Thank you for *your* opinion, but the tinderbox is not at fault here.= : The fact of the matter is that LINT is broken, as a simple 'make : buildkernel KERNCONF=3DLINT' will show. : = : The attached patch unbreaks the build. This is exactly the patch that Matt was testing. I stand by my earlier statement: if make universe doesn't show the problem, it is unreasonable to demand a fix for it. Make universe does show this problem. Warner