From owner-cvs-ports@FreeBSD.ORG  Thu Apr 12 06:20:04 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mandree.no-ip.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id B7BE21065672;
	Thu, 12 Apr 2012 06:20:03 +0000 (UTC)
	(envelope-from mandree@FreeBSD.org)
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by apollo.emma.line.org (Postfix) with ESMTP id 4772523D72F;
	Thu, 12 Apr 2012 08:20:02 +0200 (CEST)
Message-ID: <4F867412.9030704@FreeBSD.org>
Date: Thu, 12 Apr 2012 08:20:02 +0200
From: Matthias Andree <mandree@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.28) Gecko/20120313 Mnenhy/0.8.3 Thunderbird/3.1.20
MIME-Version: 1.0
To: ports-committers@FreeBSD.org
References: <201204112121.q3BLL4Fd052917@repoman.freebsd.org>
In-Reply-To: <201204112121.q3BLL4Fd052917@repoman.freebsd.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org
Subject: Re: cvs commit: ports/lang/lua Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Apr 2012 06:20:04 -0000

Am 11.04.2012 23:21, schrieb Matthias Andree:
> mandree     2012-04-11 21:21:04 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     lang/lua             Makefile 
>   Log:
>   Add explanatory comment about butchering __MAKE_CONF.
>   
>   Revision  Changes    Path
>   1.53      +3 -0      ports/lang/lua/Makefile

And no, I don't want to patch Lua's own Makefile with CFLAGS if I can
avoid it getting stomped over by our reading /etc/make.conf thrice.
I know we can patch CFLAGS that, but it has its own downsides.

Re-reading of /etc/make.conf is the harmful part, and we need to stop
doing that -- unless someone can come up with a valid reason why
variables assigned with = in /etc/make.conf (such as CFLAGS=-O3 -pipe)
need to stomp over variables deep in recursive make structures...

Related thoughts at http://wiki.freebsd.org/MatthiasAndree/LuaLessonsLearnt