From owner-cvs-ports@FreeBSD.ORG  Sun Jul  3 12:23:36 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C097106566C;
	Sun,  3 Jul 2011 12:23:36 +0000 (UTC)
	(envelope-from samm@os2.kiev.ua)
Received: from s1.sdv.com.ua (s1.sdv.com.ua [77.120.97.61])
	by mx1.freebsd.org (Postfix) with ESMTP id 451038FC18;
	Sun,  3 Jul 2011 12:23:36 +0000 (UTC)
Received: from 90-105-243-80.cust.centrio.cz ([80.243.105.90]
	helo=[192.168.100.107])
	by s1.sdv.com.ua with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.76 (FreeBSD)) (envelope-from <samm@os2.kiev.ua>)
	id 1QdLT0-0004vo-0h; Sun, 03 Jul 2011 15:08:04 +0300
Message-ID: <4E105B9B.4060602@os2.kiev.ua>
Date: Sun, 03 Jul 2011 14:07:55 +0200
From: Alex Samorukov <samm@os2.kiev.ua>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <201107021323.p62DNWeP082020@repoman.freebsd.org>
	<4E0FB8DF.90904@FreeBSD.org>
In-Reply-To: <4E0FB8DF.90904@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SA-Score: 0.8
X-SA-Report: Spam detection software, running on the system "s1.sdv.com.ua",
	has
	identified this incoming email as possible spam. The original message
	has been attached to this so you can view it (if it isn't spam) or
	label similar future email.  If you have any questions, see
	The administrator of that system for details.
	Content preview:  Hello, Thank you for comments. On 07/03/2011 02:33 AM,
	Doug
	Barton wrote: > Overall this looks good, just 2 small comments. It's not
	clear why it > uses: > > # REQUIRE: DAEMON > # BEFORE: LOGIN > >
	Instead of
	just > > # REQUIRE: LOGIN > > like most ports scripts do. Probably my
	copypaste
	from some other script. Better to replace with REQUIRE: LOGIN. [...] 
	Content analysis details:   (0.8 points, 5.0 required)
	pts rule name              description ---- ----------------------
	--------------------------------------------------
	-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
	0.0 TVD_RCVD_IP            TVD_RCVD_IP
	1.8 URIBL_BLACK Contains an URL listed in the URIBL blacklist
	[URIs: atop.in]
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Martin Wilke <miwi@FreeBSD.org>
Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo
 ports/sysutils/atop/files atop.in pkg-message.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2011 12:23:36 -0000

Hello,

Thank you for comments.

On 07/03/2011 02:33 AM, Doug Barton wrote:
> Overall this looks good, just 2 small comments. It's not clear why it 
> uses:
>
> # REQUIRE: DAEMON
> # BEFORE: LOGIN
>
> Instead of just
>
> # REQUIRE: LOGIN
>
> like most ports scripts do.
Probably my copypaste from some other script. Better to replace with 
REQUIRE: LOGIN.

 > Also the default empty assignment for _flags is neither necessary or 
desirable.

Agree. Do i need to submit PR to fix this or you can do it without it?