Date: Mon, 10 Mar 2008 00:02:23 +0100 From: Henrik Brix Andersen <henrik@brixandersen.dk> To: Felippe de Meirelles Motta <lippemail@gmail.com> Cc: Gabor Kovesdan <gabor@kovesdan.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/textproc/p5-Text-Markdown Makefile distinfo pkg-plist Message-ID: <20080309230223.GA89042@tirith.brixandersen.dk> In-Reply-To: <20080308155114.7e18ecf5@shire.freebsd.org.freebsd.org> References: <200803032139.m23LdErR001683@repoman.freebsd.org> <20080306200730.GA60953@tirith.brixandersen.dk> <47D27E4E.5070505@kovesdan.org> <20080308133826.GB77238@tirith.brixandersen.dk> <20080308155114.7e18ecf5@shire.freebsd.org.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 08, 2008 at 03:51:14PM -0300, Felippe de Meirelles Motta wrote: > Em Sat, 8 Mar 2008 14:38:26 +0100 > Henrik Brix Andersen <brix@FreeBSD.org> escreveu: >=20 > > On Sat, Mar 08, 2008 at 12:53:50PM +0100, Gabor Kovesdan wrote: > > > Henrik Brix Andersen escribi=F3: > > >> On Mon, Mar 03, 2008 at 09:39:14PM +0000, Gabor Kovesdan wrote: > > >> =20 > > >>> gabor 2008-03-03 21:39:14 UTC > > >>>=20 > > >>> FreeBSD ports repository > > >>>=20 > > >>> Modified files: > > >>> textproc/p5-Text-Markdown Makefile distinfo pkg-plist Log: > > >>> - Update 1.0.13 > > >>> - Better adjustement of dependencies > > >>> - Use PERL_CONFIGURE instead of PERL_MODBUILD > > >>> PR: ports/121027 > > >>> Submitted by: Felippe de Meirelles Motta <lippemail@gmail.com> > > >>> Approved by: maintainer > > >>> =20 > > >>=20 > > >> This update breaks at least www/ikiwiki... > > >>=20 > > >> Somehow, Text::MultiMarkdown is now known as both > > >> Text::MultiMarkdown and Text::Markdown on CPAN - (according to the > > >> change log, the authors actually planned to "steal" the > > >> Text::Markdown namespace for quite some time?) but it is not > > >> compatible with the original Text::Markdown (which is what we had > > >> as p5-Text-Markdown before this update). > > >>=20 > > >> The original version contained a Text::Markdown::Markdown() method, > > >> whereas MultiMarkdown contains a Text::Markdown::markdown() method, > > >> thus making the two incompatible (note the difference in > > >> capitalization of the method name). > > >>=20 > > >> I suggest backing this update out, restoring the original > > >> Text::Markdown functionality - and then perhaps committing this as > > >> p5-Text-MultiMarkdown, where it IMO belongs. > > >> =20 > > > Ok, I'll look at this more deeply soon, thanks for noticing this > > > issue! > >=20 > > I am currently running a patch [1] for www/ikiwiki which makes it work > > with either version of the Text::Markdown package through the > > ports tinderboxes. > >=20 > > Since other - non-FreeBSD users - will also be bitten by this change > > in the Text::Markdown module, we might as well have it fixed properly. > >=20 > > Perhaps other consumers of the textproc/p5-Text-Markdown will need > > similar patches. > >=20 > > Brix > >=20 > > [1]: http://people.freebsd.org/~brix/ports-patches/ikiwiki.diff >=20 > Hi brix, >=20 > May be i can send an downgrade to 1.0.5 and create an new port to > MultiMarkdown with lastest version ? Or what is your suggestion ? Well, even if we downgrade now we can't hold off on upgrading textproc/p5-Text-Markdown forever. I suggest we keep the upgrade as-is and instead examine the current consumers of textproc/p5-Text-Markdown to make sure they all work with the new version. I already committed a new version of www/ikiwiki with the aforementioned patch. > Thanks for report this issue! No problem :) Brix --=20 Henrik Brix Andersen <henrik@brixandersen.dk> --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) Comment: GnuPG signed iEYEARECAAYFAkfUbH8ACgkQv+Q4flTiePgnmACgwCoCsnyXGmGORE9MygB46fem hAgAnR5ksBn2atVQB/JbjPvQXkl8NArg =k3Bm -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080309230223.GA89042>