From owner-freebsd-arch@FreeBSD.ORG Tue Dec 23 13:06:54 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9937516A4CE for ; Tue, 23 Dec 2003 13:06:54 -0800 (PST) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DAA143D2F for ; Tue, 23 Dec 2003 13:06:53 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 27629 invoked from network); 23 Dec 2003 21:06:52 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 23 Dec 2003 21:06:52 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id hBNL6nM0052488; Tue, 23 Dec 2003 16:06:49 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20031223125146.K92457@root.org> Date: Tue, 23 Dec 2003 16:06:51 -0500 (EST) From: John Baldwin To: Nate Lawson X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: arch@freebsd.org cc: acpi-jp@jp.freebsd.org Subject: RE: acpi_toshiba and acpi_asus drivers X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2003 21:06:54 -0000 On 23-Dec-2003 Nate Lawson wrote: > On Thu, 18 Dec 2003, John Baldwin wrote: >> On 18-Dec-2003 Nate Lawson wrote: >> > I'm prepping/reworking some user-submitted drivers for import. I'd like >> > some comments on the directory structure. The hardware both drive is >> > everything from fans to hotkeys to lcd backlight. Both are very >> > hw-specific and do not conform to the ACPI spec although they do control >> > their functions through ACPI. >> > >> > The directory structure I'm currently working with is: >> > sys/i386/acpica/acpi_toshiba.c >> > sys/i386/acpica/acpi_asus.c >> > sys/modules/acpi_toshiba/Makefile >> > sys/modules/acpi_asus/Makefile >> > share/man/man4/acpi_toshiba.4 >> > share/man/man4/acpi_asus.4 >> > >> > One alternative is to their modules under the acpi dir (e.g., >> > sys/modules/acpi/acpi_toshiba). Also, the driver src could be >> > sys/dev/acpi_toshiba. However, a new dir for just one file seems a bit >> > much. My main concern is that as these drivers proliferate that we keep >> > the dir structure neat. >> >> Having a /sys/modules/acpi with acpi, acpi_toshiba, and acpi_asus in >> them is probably a good idea. Putting the files under sys/i386/acpica >> is also probably ok. Should the manpages be in man4.i386 rather than >> man4 though? > > Ok, this is what I'll be committing: > sys/i386/acpica/acpi_toshiba.c > sys/i386/acpica/acpi_asus.c > sys/modules/acpi/acpi/Makefile > sys/modules/acpi/acpi_toshiba/Makefile > sys/modules/acpi/acpi_asus/Makefile > share/man/man4.i386/acpi_toshiba.4 > share/man/man4.i386/acpi_asus.4 Sounds good to me, go for it. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/