Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Oct 2012 18:35:49 +0100
From:      Attilio Rao <attilio@freebsd.org>
To:        Andreas Tobler <andreast@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r241629 - in head: . etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/man/man5 share/man/man7 share/mk sys/conf sys/kern sys/modules usr....
Message-ID:  <CAJ-FndC50evYS92t3rEPEk6nHf1mBY=wR_ATWeCZCf%2BJQWz9DQ@mail.gmail.com>
In-Reply-To: <507EE97F.6010905@FreeBSD.org>
References:  <201210171116.q9HBGHHb057721@svn.freebsd.org> <507EE97F.6010905@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 17, 2012 at 6:23 PM, Andreas Tobler <andreast@freebsd.org> wrote:
> On 17.10.12 13:16, Attilio Rao wrote:
>>
>> Author: attilio
>> Date: Wed Oct 17 11:16:17 2012
>> New Revision: 241629
>> URL: http://svn.freebsd.org/changeset/base/241629
>>
>> Log:
>>    Disconnect non-MPSAFE NWFS from the build in preparation for dropping
>>    GIANT from VFS. In addition, disconnect also netncp, which is a base
>>    requirement for NWFS.
>>
>>    In the possibility of a future maintenance of the code and later
>>    readd to the FreeBSD base, maybe we should think about a better
>> location
>>    for netncp. I'm not entirely sure the / top location is actually right,
>>    however I will let network people to comment on that more specifically.
>>
>>    This is not targeted for MFC.
>
>
> Hi Attilio,
>
> I get the following error when running 'make delete-old':
>
> [root@tritium] /usr/src/> make delete-old
> "/export/devel/fbsd/src/tools/build/mk/OptionalObsoleteFiles.inc", line
> 3461: Malformed conditional (${MK_NCP} == no)
> "/export/devel/fbsd/src/Makefile.inc1", line 1566: if-less endif
> make: fatal errors encountered -- cannot continue
> *** [delete-old] Error code 1
>
> Do we have to remove the stuff in
> tools/build/mk/OptionalObsoleteFiles.inc too where we have the
>
> .if ${MK_NCP} == no
> ...
> .endif
>
> If so I'm happy to prep a patch, test and commit it.

You are indeed right. Please go ahead.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndC50evYS92t3rEPEk6nHf1mBY=wR_ATWeCZCf%2BJQWz9DQ>