From owner-freebsd-mobile  Tue Mar 13  0:15:27 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5141E37B719; Tue, 13 Mar 2001 00:15:24 -0800 (PST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2D8E2900479;
	Tue, 13 Mar 2001 01:14:02 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Message-Id: <200103130814.f2D8E2900479@harmony.village.org>
To: Soren Schmidt <sos@freebsd.dk>
Subject: Re: iomega clik! 
Cc: sos@FreeBSD.ORG, mobile@FreeBSD.ORG
In-reply-to: Your message of "Tue, 13 Mar 2001 08:40:58 +0100."
		<200103130740.IAA63705@freebsd.dk> 
References: <200103130740.IAA63705@freebsd.dk>  
Date: Tue, 13 Mar 2001 01:14:02 -0700
From: Warner Losh <imp@harmony.village.org>
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

In message <200103130740.IAA63705@freebsd.dk> Soren Schmidt writes:
: Thats why I have this in the patch:
: 
: @@ -423,5 +452,8 @@
:      int8_t ccb[16] = { ATAPI_PREVENT_ALLOW, 0, 0, 0, lock,
:                        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
:      
: -    return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0,30, NULL, NULL);
: +    if (!strncmp(ATA_PARAM(fdp->atp->controller, fdp->atp->unit)->model, 
: +                "IOMEGA Clik!", 12))
: +       return 0;
: +    return atapi_queue_cmd(fdp->atp, ccb, NULL, 0, 0, 30, NULL, NULL);
:  }

That part of the patch didn't make it to me here.  Do you really want
to do a string compare for every prevent_allow command?  I'd half way
expected you to have some kind of quirk table incase iomega comes out
with other, newer weirder drives :-).  But if that's how you want to
do it, then that should work.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message