From owner-freebsd-gnome@freebsd.org Mon Jun 6 23:55:56 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1672B6E1EA for ; Mon, 6 Jun 2016 23:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id ACA151F27 for ; Mon, 6 Jun 2016 23:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id A8464B6E1E9; Mon, 6 Jun 2016 23:55:56 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7E8BB6E1E8 for ; Mon, 6 Jun 2016 23:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 987E11F26 for ; Mon, 6 Jun 2016 23:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u56NtueK016039 for ; Mon, 6 Jun 2016 23:55:56 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 209077] net/opal: Fix build with libc++ 3.8.0 Date: Mon, 06 Jun 2016 23:55:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2016 23:55:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209077 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: truckman Date: Mon Jun 6 23:55:08 UTC 2016 New revision: 416491 URL: https://svnweb.freebsd.org/changeset/ports/416491 Log: Fix type for abs() calls in net/opal During the exp-run in bug 208158, it was found that net/opal gives errors with libc++ 3.8.0 [1]: ../common/mpi.cxx:135:18: error: call to 'abs' is ambiguous distance =3D ( abs(MPIs[i].width - desiredWidth ) * ^~~ This is because abs() is being called with unsigned arguments. Fix this by casting the arguments to the appropriate signed type. This mimics what happens with older libraries where the only version of abs() was the one in , which is prototyped: int abs(int) Correct functioning of this expression relies on how integer overflow actually behaves, which is actually undefined in the C++ standard. PR: 209077 Submitted by: dim Changes: head/net/opal/files/patch-plugins_video_common_mpi.cxx --=20 You are receiving this mail because: You are the assignee for the bug.=