From owner-cvs-all@FreeBSD.ORG Tue Nov 4 00:45:58 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 43C0816A4DC; Tue, 4 Nov 2003 00:45:58 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id CF18843FDF; Tue, 4 Nov 2003 00:45:56 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id hA48jtM8039998; Tue, 4 Nov 2003 09:45:55 +0100 (CET) (envelope-from phk@phk.freebsd.dk) To: Mike Silbersack From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 04 Nov 2003 02:26:24 CST." <20031104022403.J625@odysseus.silby.com> Date: Tue, 04 Nov 2003 09:45:55 +0100 Message-ID: <39997.1067935555@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Kirk McKusick Subject: Re: cvs commit: src/sys/kern kern_timeout.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2003 08:45:58 -0000 In message <20031104022403.J625@odysseus.silby.com>, Mike Silbersack writes: > >On Tue, 4 Nov 2003, Kirk McKusick wrote: > >> mckusick 2003/11/04 00:03:11 PST >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_timeout.c >> Log: >> Get rid of DIAGNOSTIC that gives false positives on slow CPUs. > >That doesn't seem to be a very good reason for removing the code. As only >the highest value seen so far is printed, the code is generally pretty >quiet once it stops complaining about how long the MII routines take. I agree, I am unhappy about this removal too. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.