From nobody Tue Feb 17 20:55:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fFsNn61VNz6S4X0; Tue, 17 Feb 2026 20:55:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fFsNn5BtQz41Dj; Tue, 17 Feb 2026 20:55:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771361737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fov85U0CbhId9w4AxEtuNisCqtDvJqBapNfXbDQZccs=; b=w30aByfoGjC9xy06nrLQb9l8cBZ/HkK+QgID+HAXXtFIXu8+TC5Ihn5sMQE7JKkKiOi8Hk hMoTmRqiNq0oSFh29821wrFk/fIZNou7s4A+XffzRo4oEb930w+yS0YmlggET2rdubLj+f xzeva3Hnb5ggPAAnZqLBO5H7Wl3ErO+L8vh+cJ8qLAtdZIEfpApfPnPv/58/fcb8+op8pq Mqv7tLaVavZbSQXcnQt1nfx7mB+61+MLyhC4mm1dTrp1eL7tQN8txp5o3NIDAOTVERCw6X Xm0wjCpLjOPB54KjYPaKQmkM7td9GmM57Xwsiw1lEaqM0z6Nc+FAha3+8sSDaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771361737; a=rsa-sha256; cv=none; b=nnz3Eu+jW5/iR5DLF430n8EgzwYXw5q1d3f21twRxhkoE93JvgOZZ49w0wiSF+P2A1LR3b huAh8v9iskBraDnuolu4nZkrNE8BtMxuO5/LjTBmRkL0EB7x7RV0VnBfY4UQSZhAPMGSCe wkXSR22OA2YSGI3zQLnKmrpVWqJ6Gp/ovCw3O6wPMyLfZf9wyuipbOsFX3qKl1iF0mj3vs Kqdoq+JQq5ZwADMn7j4gXfY1B6pXExrDUNA/ia7wkRAgfObV+RSvmoteeHa64Bcch99q09 XqA0hFT3Xp/axFObpqtj80S8Lu0E7H6t26dveWZuXydnuCMQvYP9QTBAo8Qb9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771361737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fov85U0CbhId9w4AxEtuNisCqtDvJqBapNfXbDQZccs=; b=jlkx55TdHVLlMWngNdPnh/W0B9SZjgKt7BOKURh39teVdVHhcPhc83KJi5JOnyLB9pUQ9i dzzudNwAFDqrEHxss/KRAPUtgCCUmItMy5mQRAf1OAAR7/6Hov7wFGmSH/dgrVq1x7OEr3 mjc0EK0wjZC7XdH0Q0itl/Z8D4OiQeaZE9gNhTmRK3ukJleexw5cPDA9RQVxwPoykU/XsO 63Bj3a0nJhTXiby2FJJLFOpuuLtu+W+cB9COrLhjUuVp1EB4AccmD85rx/biao2SZnRZEC Mid8CthUszIBZ/b9mLvP2otcnk34XrMdzId27112Ub11iBRjgywMAd/m66VlvQ== Received: from [IPV6:2601:5c0:4202:5670:475:8f88:8099:d67] (unknown [IPv6:2601:5c0:4202:5670:475:8f88:8099:d67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fFsNn2zg9z9KJ; Tue, 17 Feb 2026 20:55:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9a743a8a-fbba-4a2b-89d4-5d6745a01516@FreeBSD.org> Date: Tue, 17 Feb 2026 15:55:36 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 97ce8f7d2b8e - main - amd64: define and use STACKALIGN and REDZONE_SZ Content-Language: en-US To: Konstantin Belousov Cc: "Enji Cooper (yaneurabeya)" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <698a1ffe.26e3c.47182d66@gitrepo.freebsd.org> <1d35e758-ff0d-4fb3-9a4c-a0fc69182d41@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/17/26 15:01, Konstantin Belousov wrote: > On Tue, Feb 17, 2026 at 02:42:20PM -0500, John Baldwin wrote: >> On 2/16/26 21:44, Konstantin Belousov wrote: >>> On Mon, Feb 16, 2026 at 05:01:58PM -0800, Enji Cooper (yaneurabeya) wrote: >>>> >>>>> On Feb 9, 2026, at 9:57 AM, Konstantin Belousov wrote: >>>>> >>>>> The branch main has been updated by kib: >>>>> >>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 >>>>> >>>>> commit 97ce8f7d2b8eff42460f60e8c49d9849b58b6e81 >>>>> Author: Konstantin Belousov >>>>> AuthorDate: 2026-02-07 00:36:44 +0000 >>>>> Commit: Konstantin Belousov >>>>> CommitDate: 2026-02-09 17:57:00 +0000 >>>>> >>>>> amd64: define and use STACKALIGN and REDZONE_SZ >>>>> >>>>> Reviewed by: brooks, emaste, jhb >>>>> Sponsored by: The FreeBSD Foundation >>>>> MFC after: 1 week >>>>> Differential revision: https://reviews.freebsd.org/D55151 >>>> >>>> Hi kib@! >>>> It looks like this broke the build with gcc12 on main: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/2893/console . >>> >>> https://reviews.freebsd.org/D55319 >>> might be the fix. >> >> I have the same thing at https://reviews.freebsd.org/D55161 >> >> Per my comments there, I do think it might break 32-bit kernels, but we probably >> don't care about that. (Namely, if rounddown2() is used on a type larger than >> uintptr_t such as trunc_page on a vm_paddr_t on i386, this change truncates the >> value). >> >> If we really care, we could use _Generic or the like to only use the uintptr_t >> casts for pointer types. > > I must admit that I initially wrote the cast to uintmax_t, and only then > looked at the nearby code (__builtin_align_up() and others). Since > uintptr_t was good enough for them, I used it in the patch as well. I'm happy to just merge it as after my last batch of merges it is now the last patch needed to build aarch64 kernels with GCC. Userspace for aarch64 for GCC needs one more fix (though I think we want to fix it in the compiler rather than in src, GCC isn't passing -lgcc when linking shared libraries for some reason). -- John Baldwin