From owner-cvs-all@FreeBSD.ORG Tue Oct 16 21:46:19 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86C1B16A417 for ; Tue, 16 Oct 2007 21:46:19 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.237]) by mx1.freebsd.org (Postfix) with ESMTP id 38FFC13C46E for ; Tue, 16 Oct 2007 21:46:19 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1828945wxd for ; Tue, 16 Oct 2007 14:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=15JYcXWDwp4z8n51NzXkt3wkfmrpFrsdZelBoITaWPA=; b=p/VQBSjxnhGpTOLDCNnYOB7vodgjG9sVgHbqkuJ2Tzih8RBtXFjN7cyLDnd4MRkQXZVd8OvEtAypRl//Lpyv91lR13BnFR2M71h76ypi0DSPgl1UWZ/V+1GQFroPQ/lZsN7RscWEZOFXMmq+bb27Hkfb6luOekzwO+i7N0wGWts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=B+TP40Yuh8eDf2tj7KgVSou1QxanGbAJu1U6cv/j5jqPQA06SfbzhgBfjHwL+5jCfoGnvNU8Wf3Ovjwy0w1yB/mwWYrJ2VOFh+WttcNrWWHeNDS6sJjIMvQmRkjKX1J/jaeIsDEkhbY16oN5UB6Jksc7YGj7ioM2C2kvtCD4ORw= Received: by 10.90.93.6 with SMTP id q6mr11473604agb.1192571178119; Tue, 16 Oct 2007 14:46:18 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Tue, 16 Oct 2007 14:46:18 -0700 (PDT) Message-ID: Date: Tue, 16 Oct 2007 17:46:18 -0400 From: "Constantine A. Murenin" To: "John Baldwin" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:46:19 -0000 On 16/10/2007, John Baldwin wrote: > On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > > Constantine asked for review several times on -current. He got some > > reviews several times for commits to perforce. He incorporated > > suggestions from those reviews, or explained why it is like it is and > > why he can not switch (with no replies with suggestions how to solve > > the problems he sees with the suggestions). Now you come and ask why > > nobody pointed out some flaws before (without telling us which > > technical flaws you talk about). > > At least from my point of view this is not quite accurate as pretty much all > my feedback to the p4 commits was ignored with basically "Well, I don't like > doing it that way". Specifically, with regards to creating dynamic sysctl > trees, Constantine feels that sysctl_add_oid(9) is a hack rather than > recognizing that this is a feature of FreeBSD's sysctl system despite > repeated e-mails on the subject. Dear John, I have specifically addressed this concern of yours just several weeks ago. Please see the following message, which you've never replied to: http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html I've used the documented parts of the FreeBSD's sysctl interface to preserve 100% userland compatibility with OpenBSD. I cannot possibly see why you would have a problem with such an approach other than for the fact that OpenBSD is not a proprietary system with wealthy sponsors. Cheers, Constantine.