From owner-freebsd-bugs@FreeBSD.ORG  Mon Feb 11 13:20:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 35468A6C
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 11 Feb 2013 13:20:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 23F168AA
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 11 Feb 2013 13:20:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1BDK10M008951
 for <freebsd-bugs@freefall.freebsd.org>; Mon, 11 Feb 2013 13:20:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1BDK1qV008949;
 Mon, 11 Feb 2013 13:20:01 GMT (envelope-from gnats)
Date: Mon, 11 Feb 2013 13:20:01 GMT
Message-Id: <201302111320.r1BDK1qV008949@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: kern/176027: flow control systcl consistency for em drivers
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Gleb Smirnoff <glebius@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2013 13:20:01 -0000

The following reply was made to PR kern/176027; it has been noted by GNATS.

From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Olivier Cochard-Labbe <olivier@cochard.me>
Cc: freebsd-gnats-submit@FreeBSD.org, jfv@FreeBSD.org
Subject: Re: kern/176027: flow control systcl consistency for em drivers
Date: Mon, 11 Feb 2013 17:10:20 +0400

 On Mon, Feb 11, 2013 at 11:48:51AM +0000, Olivier Cochard-Labbe wrote:
 O> 
 O> >Number:         176027
 O> >Category:       kern
 O> >Synopsis:       flow control systcl consistency for em drivers
 O> >Confidential:   no
 O> >Severity:       non-critical
 O> >Priority:       low
 O> >Responsible:    freebsd-bugs
 O> >State:          open
 O> >Quarter:        
 O> >Keywords:       
 O> >Date-Required:
 O> >Class:          sw-bug
 O> >Submitter-Id:   current-users
 O> >Arrival-Date:   Mon Feb 11 11:50:00 UTC 2013
 O> >Closed-Date:
 O> >Last-Modified:
 O> >Originator:     Olivier Cochard-Labbe
 O> >Release:        9.1-RELEASE
 O> >Organization:
 O> BSD Router Project
 O> >Environment:
 O> >Description:
 O> On my systems em(4) flow control can be configured with:
 O> dev.em.0.fc (if chipset depends of if_em.c)
 O> or
 O> dev.em.0.flow_control (if chipset depends of if_lem.c)
 O> 
 O> For more consistency (but a POLA?), here is a small patch for if_lem.c that replace 'flow_control' usage by 'fc' usage.
 O> 
 O> 
 O> >How-To-Repeat:
 O> 
 O> >Fix:
 O> Applying the patch.
 O> 
 O> Patch attached with submission follows:
 O> 
 O> --- sys/dev/e1000/if_lem.c.orig	2013-02-11 10:21:00.000000000 +0100
 O> +++ sys/dev/e1000/if_lem.c	2013-02-11 10:21:20.000000000 +0100
 O> @@ -458,7 +458,7 @@
 O>  #endif
 O>  
 O>          /* Sysctl for setting the interface flow control */
 O> -	lem_set_flow_cntrl(adapter, "flow_control",
 O> +	lem_set_flow_cntrl(adapter, "fc",
 O>  	    "flow control setting",
 O>  	    &adapter->fc_setting, lem_fc_setting);
 
 I'd prefer the opposite: substitute for "flow_control" in if_em.c.
 
 Jack, what's your opinion?
 
 -- 
 Totus tuus, Glebius.